fix: dont fetch tags if tags arg is empty array

anolilab · Apr 9, 2022 · 3a79558 · 3a79558
1 parent f502f89
commit 3a79558
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 9 deletions.
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -20,8 +20,7 @@ jobs:
     runs-on: ubuntu-20.04
     steps:
       - uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
+
       - uses: actions/setup-node@v3
         with:
           node-version: 16
@@ -40,8 +39,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v3
-        with:
-          fetch-depth: 0
+
       - uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}

diff --git a/lib/git.js b/lib/git.js
@@ -12,7 +12,7 @@ import { execaSync } from "execa";
  * @internal
  */
 function getTags(branch, execaOptions, filters) {
-	let tags = execaSync("git", ["tag", "--merged", branch], execaOptions).stdout;
+	let tags = execaSync("git", ["tag", "--merged"], execaOptions).stdout;
 	tags = tags
 		.split("\n")
 		.map((tag) => tag.trim())

diff --git a/lib/updateDeps.js b/lib/updateDeps.js
@@ -58,8 +58,8 @@ const getNextPreVersion = (pkg, tags) => {
 	// 3. Resolve the versions from the tags
 	// TODO: replace {cwd: '.'} with multiContext.cwd
 	if (pkg.name) tagFilters.push(pkg.name);
-	if (!tags || !tags.length) {
-		tags = getTags(pkg._branch, { cwd: "." }, tagFilters);
+	if (!tags) {
+		tags = getTags(pkg._branch, { cwd: process.cwd() }, tagFilters);
 	}
 
 	const lastPreRelTag = getPreReleaseTag(lastVersion);

diff --git a/test/bin/cli.test.js b/test/bin/cli.test.js
@@ -35,7 +35,7 @@ describe("multi-semantic-release CLI", () => {
 		// expect(out).toMatch("Released 4 of 4 packages, semantically!");
 
 		try {
-			await execa("node", [filepath, "-- --no-sequential-prepare --no-ci"], { cwd });
+			await execa("node", [filepath, "-- --no-sequential-prepare", "--no-ci"], { cwd });
 		} catch (res) {
 			const { stdout, stderr, exitCode } = res;
 
@@ -58,7 +58,7 @@ describe("multi-semantic-release CLI", () => {
 
 		// Run via command line.
 		const out = (
-			await execa("node", [filepath, "-- --ignore-packages=packages/c/**,packages/d/**  --no-ci"], { cwd })
+			await execa("node", [filepath, "-- --ignore-packages=packages/c/**,packages/d/**", "--no-ci"], { cwd })
 		).stdout;
 		expect(out).toMatch("Started multirelease! Loading 2 packages...");
 		expect(out).toMatch("Released 2 of 2 packages, semantically!");