fix: fix getNextVersion resolver

anolilab · Nov 23, 2020 · 7275ae7 · 7275ae7
1 parent bcb40d5
commit 7275ae7
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 2 deletions.
diff --git a/lib/updateDeps.js b/lib/updateDeps.js
@@ -12,7 +12,9 @@ const semver = require("semver");
 const getNextVersion = (pkg) => {
 	const lastVersion = pkg._lastRelease && pkg._lastRelease.version;
 
-	return lastVersion && typeof pkg._nextType === "string" ? semver.inc(lastVersion, pkg._nextType) : "1.0.0";
+	return lastVersion && typeof pkg._nextType === "string"
+		? semver.inc(lastVersion, pkg._nextType)
+		: lastVersion || "1.0.0";
 };
 
 /**

diff --git a/test/lib/updateDeps.test.js b/test/lib/updateDeps.test.js
@@ -1,4 +1,4 @@
-const { resolveReleaseType, resolveNextVersion } = require("../../lib/updateDeps");
+const { resolveReleaseType, resolveNextVersion, getNextVersion } = require("../../lib/updateDeps");
 
 describe("resolveNextVersion()", () => {
 	// prettier-ignore
@@ -140,3 +140,22 @@ describe("resolveReleaseType()", () => {
 		});
 	});
 });
+
+describe("getNextVersion()", () => {
+	// prettier-ignore
+	const cases = [
+		[undefined, "patch", "1.0.0"],
+		["1.0.0", "patch", "1.0.1"],
+		["2.0.0", undefined, "2.0.0"],
+	]
+
+	cases.forEach(([lastVersion, releaseType, nextVersion]) => {
+		it(`${lastVersion} and ${releaseType} gives ${nextVersion}`, () => {
+			// prettier-ignore
+			expect(getNextVersion({
+				_nextType: releaseType,
+				_lastRelease: {version: lastVersion}
+			})).toBe(nextVersion);
+		});
+	});
+});