Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic block calls in the Reg -> CASM translation #3238

Merged
merged 8 commits into from
Dec 6, 2024
Merged

Conversation

lukaszcz
Copy link
Collaborator

@lukaszcz lukaszcz commented Dec 6, 2024

  • Closes Miscompilation in the Cairo backend #3237
  • The order of arguments passed to the next basic block was inconsistent among different branches of an if/case. This manifested itself only when the branches ended with different operations (e.g., one with a call, another with assignment), the result of the branching was used later on (the branching was not at tail position), and variables declared before the branch were used after it in a specific way.

@lukaszcz lukaszcz added this to the 0.6.9 milestone Dec 6, 2024
@lukaszcz lukaszcz self-assigned this Dec 6, 2024
lukaszcz and others added 2 commits December 6, 2024 12:28
Co-authored-by: Jan Mas Rovira <janmasrovira@gmail.com>
Co-authored-by: Jan Mas Rovira <janmasrovira@gmail.com>
@lukaszcz lukaszcz requested a review from janmasrovira December 6, 2024 11:28
janmasrovira
janmasrovira previously approved these changes Dec 6, 2024
@janmasrovira janmasrovira merged commit d815855 into main Dec 6, 2024
4 checks passed
@janmasrovira janmasrovira deleted the fix-casm-bug branch December 6, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Miscompilation in the Cairo backend
2 participants