-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix basic block calls in the Reg -> CASM translation #3238
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lukaszcz
commented
Dec 6, 2024
- Closes Miscompilation in the Cairo backend #3237
- The order of arguments passed to the next basic block was inconsistent among different branches of an if/case. This manifested itself only when the branches ended with different operations (e.g., one with a call, another with assignment), the result of the branching was used later on (the branching was not at tail position), and variables declared before the branch were used after it in a specific way.
lukaszcz
force-pushed
the
fix-casm-bug
branch
from
December 6, 2024 10:27
8ab67dd
to
fe3b69f
Compare
janmasrovira
reviewed
Dec 6, 2024
janmasrovira
force-pushed
the
fix-casm-bug
branch
from
December 6, 2024 10:58
fe3b69f
to
8a6abbb
Compare
Co-authored-by: Jan Mas Rovira <janmasrovira@gmail.com>
Co-authored-by: Jan Mas Rovira <janmasrovira@gmail.com>
lukaszcz
commented
Dec 6, 2024
janmasrovira
previously approved these changes
Dec 6, 2024
janmasrovira
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.