Skip to content

update note encryption #395

update note encryption

update note encryption #395

GitHub Actions / Clippy (MSRV) failed Aug 21, 2023 in 0s

Clippy (MSRV)

13 errors

Details

Results

Message level Amount
Internal compiler error 0
Error 13
Warning 0
Note 0
Help 0

Versions

  • rustc 1.65.0 (897e37553 2022-11-02)
  • cargo 1.65.0 (4bc8f24d3 2022-10-20)
  • clippy 0.1.65 (897e375 2022-11-02)

Annotations

Check failure on line 170 in masp_primitives/src/transaction/components/sapling/builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

using `clone` on type `sapling::Note` which implements the `Copy` trait

error: using `clone` on type `sapling::Note` which implements the `Copy` trait
   --> masp_primitives/src/transaction/components/sapling/builder.rs:170:64
    |
170 |         let encryptor = sapling_note_encryption::<P>(self.ovk, self.note.clone(), self.memo);
    |                                                                ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.note`
    |
    = note: `-D clippy::clone-on-copy` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check failure on line 69 in masp_primitives/src/transaction/components/sapling/builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

you are deriving `PartialEq` and can implement `Eq`

error: you are deriving `PartialEq` and can implement `Eq`
  --> masp_primitives/src/transaction/components/sapling/builder.rs:69:24
   |
69 | #[derive(Debug, Clone, PartialEq)]
   |                        ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
   |
   = note: `-D clippy::derive-partial-eq-without-eq` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

Check failure on line 257 in masp_primitives/src/transaction/builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `u64`

error: useless conversion to the same type: `u64`
   --> masp_primitives/src/transaction/builder.rs:257:81
    |
257 |             .add_output(&mut self.rng, ovk, to, asset_type, NoteValue::from_raw(value.into()), memo)
    |                                                                                 ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 871 in masp_primitives/src/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `sapling::NoteValue`

error: useless conversion to the same type: `sapling::NoteValue`
   --> masp_primitives/src/sapling.rs:871:24
    |
871 |                 value: value.into(),
    |                        ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 644 in masp_primitives/src/sapling/note_encryption.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `u64`

error: useless conversion to the same type: `u64`
   --> masp_primitives/src/sapling/note_encryption.rs:644:47
    |
644 |         let note = pa.create_note(asset_type, value.into(), rseed);
    |                                               ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 146 in masp_primitives/src/sapling/note_encryption.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `u64`

error: useless conversion to the same type: `u64`
   --> masp_primitives/src/sapling/note_encryption.rs:146:43
    |
146 |     let note = to.create_note(asset_type, value.into(), rseed);
    |                                           ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
    |
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 546 in masp_primitives/src/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

associated function `to_le_bits` is never used

error: associated function `to_le_bits` is never used
   --> masp_primitives/src/sapling.rs:546:19
    |
546 |     pub(crate) fn to_le_bits(self) -> BitArray<[u8; 8], Lsb0> {
    |                   ^^^^^^^^^^
    |
    = note: `-D dead-code` implied by `-D warnings`

Check failure on line 170 in masp_primitives/src/transaction/components/sapling/builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

using `clone` on type `sapling::Note` which implements the `Copy` trait

error: using `clone` on type `sapling::Note` which implements the `Copy` trait
   --> masp_primitives/src/transaction/components/sapling/builder.rs:170:64
    |
170 |         let encryptor = sapling_note_encryption::<P>(self.ovk, self.note.clone(), self.memo);
    |                                                                ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.note`
    |
    = note: `-D clippy::clone-on-copy` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check failure on line 69 in masp_primitives/src/transaction/components/sapling/builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

you are deriving `PartialEq` and can implement `Eq`

error: you are deriving `PartialEq` and can implement `Eq`
  --> masp_primitives/src/transaction/components/sapling/builder.rs:69:24
   |
69 | #[derive(Debug, Clone, PartialEq)]
   |                        ^^^^^^^^^ help: consider deriving `Eq` as well: `PartialEq, Eq`
   |
   = note: `-D clippy::derive-partial-eq-without-eq` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

Check failure on line 257 in masp_primitives/src/transaction/builder.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `u64`

error: useless conversion to the same type: `u64`
   --> masp_primitives/src/transaction/builder.rs:257:81
    |
257 |             .add_output(&mut self.rng, ovk, to, asset_type, NoteValue::from_raw(value.into()), memo)
    |                                                                                 ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 871 in masp_primitives/src/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `sapling::NoteValue`

error: useless conversion to the same type: `sapling::NoteValue`
   --> masp_primitives/src/sapling.rs:871:24
    |
871 |                 value: value.into(),
    |                        ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 146 in masp_primitives/src/sapling/note_encryption.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

useless conversion to the same type: `u64`

error: useless conversion to the same type: `u64`
   --> masp_primitives/src/sapling/note_encryption.rs:146:43
    |
146 |     let note = to.create_note(asset_type, value.into(), rseed);
    |                                           ^^^^^^^^^^^^ help: consider removing `.into()`: `value`
    |
    = note: `-D clippy::useless-conversion` implied by `-D warnings`
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion

Check failure on line 546 in masp_primitives/src/sapling.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (MSRV)

associated function `to_le_bits` is never used

error: associated function `to_le_bits` is never used
   --> masp_primitives/src/sapling.rs:546:19
    |
546 |     pub(crate) fn to_le_bits(self) -> BitArray<[u8; 8], Lsb0> {
    |                   ^^^^^^^^^^
    |
    = note: `-D dead-code` implied by `-D warnings`