Wallet bip39 / bip32 / bip44 support #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karbyshev
changed the title
karbyshev
force-pushed
the
aleks/wallet-deterministic
branch
from
554adfe to
7b5a7b1
Compare
tzemanovic
reviewed
Feb 6, 2023
tzemanovic
reviewed
Feb 6, 2023
tzemanovic
reviewed
Feb 6, 2023
karbyshev
force-pushed
the
aleks/wallet-deterministic
branch
from
13bb6c9 to
87ed83e
Compare
karbyshev
commented
Apr 12, 2023
karbyshev
force-pushed
the
aleks/wallet-deterministic
branch
from
d643ee1 to
0e5a512
Compare
karbyshev
changed the title
karbyshev
force-pushed
the
aleks/wallet-deterministic
branch
from
d4a0094 to
1e0a7d8
Compare
karbyshev
changed the title
tzemanovic
reviewed
May 4, 2023
tzemanovic
reviewed
May 4, 2023
tzemanovic
reviewed
May 4, 2023
tzemanovic
reviewed
May 4, 2023
tzemanovic
reviewed
May 4, 2023
tzemanovic
reviewed
May 4, 2023
karbyshev
force-pushed
the
aleks/wallet-deterministic
branch
from
32afdc4 to
71a6b1b
Compare
Closed
|
pls update wasm |
tzemanovic
previously approved these changes
May 9, 2023
10 tasks
karbyshev
force-pushed
the
aleks/wallet-deterministic
branch
3 times, most recently
from
c425965 to
e5041e1
Compare
tzemanovic
force-pushed
the
aleks/wallet-deterministic
branch
from
e5041e1 to
1d5b9d7
Compare
tzemanovic
force-pushed
the
aleks/wallet-deterministic
branch
from
1d5b9d7 to
0aff548
Compare
|
pls update wasm |
tzemanovic
approved these changes
May 20, 2023
tzemanovic
added a commit
that referenced
this pull request
May 20, 2023
* aleks/wallet-deterministic: [ci] wasm checksums update wasm: update checksums Add changelog entry Fix dependencies Update Cargo.lock Use Zeroizing instead of SecStr Simplify method signature Improve comment Apply suggestions from code review Additional test cases for ed25519 Additional test cases for secp256k1 Remove outdated comment Add error messages Fix path hardening Warn user if path coin type and crypto scheme are incompatible Add unit tests for HD wallet functionality Rework CLI options; fix bugs feat: add HD derivation path support Add derivation paths Revert "Support mnemonic codes only for ed25519 scheme." Support mnemonic codes only for ed25519 scheme. Refactor Apply suggestions from code review Clean code, minor refactoring Zeroize user mnemonic phrase input Fix comment Check if the public key hash already known Add test case Refactoring Improve messages Improve comments and messages Keypair / wallet recovery from mnemonic code Fix help messages Draft of wallet bip39 support
tzemanovic
added a commit
that referenced
this pull request
May 21, 2023
* aleks/wallet-deterministic: [ci] wasm checksums update wasm: update checksums Add changelog entry Fix dependencies Update Cargo.lock Use Zeroizing instead of SecStr Simplify method signature Improve comment Apply suggestions from code review Additional test cases for ed25519 Additional test cases for secp256k1 Remove outdated comment Add error messages Fix path hardening Warn user if path coin type and crypto scheme are incompatible Add unit tests for HD wallet functionality Rework CLI options; fix bugs feat: add HD derivation path support Add derivation paths Revert "Support mnemonic codes only for ed25519 scheme." Support mnemonic codes only for ed25519 scheme. Refactor Apply suggestions from code review Clean code, minor refactoring Zeroize user mnemonic phrase input Fix comment Check if the public key hash already known Add test case Refactoring Improve messages Improve comments and messages Keypair / wallet recovery from mnemonic code Fix help messages Draft of wallet bip39 support
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements HD wallet derivation / recovery from a given mnemonic code.