Rebased: Tighten security around potential P2P issues #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 17, 2023
Closed
adrianbrink
force-pushed
the
tiago/rebased-validate-tx-bytes-len
branch
from
c95d2dd to
8a599fb
Compare
adrianbrink
added a commit
that referenced
this pull request
Nov 17, 2023
* tiago/rebased-validate-tx-bytes-len: Changelog Update masp proofs New unit tests Validate tx bytes in CheckTx and ProcessProposal Add too large tx error Validate tx sizes storage api Add max tx bytes to genesis template Fix docstr Add max tx bytes protocol param Tune block and mempool CometBFT params
adrianbrink
force-pushed
the
tiago/rebased-validate-tx-bytes-len
branch
from
8a599fb to
1dd91c9
Compare
adrianbrink
added a commit
that referenced
this pull request
Nov 17, 2023
* tiago/rebased-validate-tx-bytes-len: Changelog Update masp proofs New unit tests Validate tx bytes in CheckTx and ProcessProposal Add too large tx error Validate tx sizes storage api Add max tx bytes to genesis template Fix docstr Add max tx bytes protocol param Tune block and mempool CometBFT params
tzemanovic
approved these changes
Nov 20, 2023
tzemanovic
added a commit
that referenced
this pull request
Nov 20, 2023
* origin/tiago/rebased-validate-tx-bytes-len: Changelog Update masp proofs New unit tests Validate tx bytes in CheckTx and ProcessProposal Add too large tx error Validate tx sizes storage api Add max tx bytes to genesis template Fix docstr Add max tx bytes protocol param Tune block and mempool CometBFT params
tzemanovic
added a commit
that referenced
this pull request
Nov 20, 2023
This was referenced Mar 4, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Decrease CometBFT block sizes, and add a new genesis parameter used to validate the max tx bytes allowed for a certain tx to be included in the mempool (passes
CheckTx, therefore is broadcasted and disseminated over CometBFT's P2P layer) and inProcessProposal.Indicate on which release or other PRs this topic is based on
v0.26.0Rebased version of #2131 from
v0.25.0Checklist before merging to
draft