Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs for trunc_div functio #2332

Merged
merged 2 commits into from
Dec 28, 2023

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

  • updated comment provides a detailed explanation of how trunc_div works

@Fraccaman Fraccaman closed this Dec 27, 2023
@DoTheBestToGetTheBest
Copy link
Contributor Author

@Fraccaman hey is there a reason for closing this ?

@brentstone brentstone reopened this Dec 27, 2023
@brentstone
Copy link
Collaborator

@Fraccaman hey is there a reason for closing this ?

It was accidental. Thanks for the contribution, this will be merged soon after I clean it up a bit.

@DoTheBestToGetTheBest
Copy link
Contributor Author

@Fraccaman hey is there a reason for closing this ?

It was accidental. Thanks for the contribution, this will be merged soon after I clean it up a bit.

thank you for your answer, i made another pr which was closed too( i don't know why too)

@brentstone
Copy link
Collaborator

@DoTheBestToGetTheBest Ah I see this is from a fork. Can you actually just remove the last commit and force-push back here with only your first commit? Your last commit does not obey our linting conventions. You can run make clippy within the namada repo to check the linting locally.

@DoTheBestToGetTheBest
Copy link
Contributor Author

h I see this is from a fork. Can you actually just remove the last commit and force-push back here with only your first commit? Your last commit does not obey our linting conventions.

so sorry not behind computer these days. I'm not in main branch and actual branch is not protected i guess you can do it if you have time ?

@brentstone
Copy link
Collaborator

@Fraccaman hey is there a reason for closing this ?

It was accidental. Thanks for the contribution, this will be merged soon after I clean it up a bit.

thank you for your answer, i made another pr which was closed too( i don't know why too)

Feel free to let me know which one it is, but in general since announcing the airdrop we have received lots of spammy PRs that contribute very little and may appear to be attempts at airdrop farming, so we have been closing lots of them. We do want to merge legitimate attempts at contributing to the repo though.

@DoTheBestToGetTheBest
Copy link
Contributor Author

@Fraccaman hey is there a reason for closing this ?

It was accidental. Thanks for the contribution, this will be merged soon after I clean it up a bit.

thank you for your answer, i made another pr which was closed too( i don't know why too)

Feel free to let me know which one it is, but in general since announcing the airdrop we have received lots of spammy PRs that contribute very little and may appear to be attempts at airdrop farming, so we have been closing lots of them. We do want to merge legitimate attempts at contributing to the repo though.

it was this pr : #2333

don't worry, i'm not looking to get the airdrop :)

i'm starting to learn about namada and trying to contribute on it while learning it :)

would be greats also to join a telegram or something where namada devs discuss :)

@brentstone brentstone force-pushed the better-trunc_div-docs branch from 760adde to d6982fe Compare December 27, 2023 23:46
@brentstone
Copy link
Collaborator

@Fraccaman hey is there a reason for closing this ?

It was accidental. Thanks for the contribution, this will be merged soon after I clean it up a bit.

thank you for your answer, i made another pr which was closed too( i don't know why too)

Feel free to let me know which one it is, but in general since announcing the airdrop we have received lots of spammy PRs that contribute very little and may appear to be attempts at airdrop farming, so we have been closing lots of them. We do want to merge legitimate attempts at contributing to the repo though.

it was this pr : #2333

don't worry, i'm not looking to get the airdrop :)

i'm starting to learn about namada and trying to contribute on it while learning it :)

would be greats also to join a telegram or something where namada devs discuss :)

Awesome to hear! There is an active discord channel with several pages for devs and testnet usage. You should check them out and try using the latest testnets :). https://discord.com/invite/namada

@DoTheBestToGetTheBest
Copy link
Contributor Author

@Fraccaman hey is there a reason for closing this ?

It was accidental. Thanks for the contribution, this will be merged soon after I clean it up a bit.

thank you for your answer, i made another pr which was closed too( i don't know why too)

Feel free to let me know which one it is, but in general since announcing the airdrop we have received lots of spammy PRs that contribute very little and may appear to be attempts at airdrop farming, so we have been closing lots of them. We do want to merge legitimate attempts at contributing to the repo though.

it was this pr : #2333
don't worry, i'm not looking to get the airdrop :)
i'm starting to learn about namada and trying to contribute on it while learning it :)
would be greats also to join a telegram or something where namada devs discuss :)

Awesome to hear! There is an active discord channel with several pages for devs and testnet usage. You should check them out and try using the latest testnets :). https://discord.com/invite/namada

also what do you suggest for me documentation to know like everything about anoma please? how the chain works, transactions type here, consesus, etc etc

@brentstone
Copy link
Collaborator

@Fraccaman hey is there a reason for closing this ?

It was accidental. Thanks for the contribution, this will be merged soon after I clean it up a bit.

thank you for your answer, i made another pr which was closed too( i don't know why too)

Feel free to let me know which one it is, but in general since announcing the airdrop we have received lots of spammy PRs that contribute very little and may appear to be attempts at airdrop farming, so we have been closing lots of them. We do want to merge legitimate attempts at contributing to the repo though.

it was this pr : #2333
don't worry, i'm not looking to get the airdrop :)
i'm starting to learn about namada and trying to contribute on it while learning it :)
would be greats also to join a telegram or something where namada devs discuss :)

Awesome to hear! There is an active discord channel with several pages for devs and testnet usage. You should check them out and try using the latest testnets :). https://discord.com/invite/namada

also what do you suggest for me documentation to know like everything about anoma please? how the chain works, transactions type here, consesus, etc etc

You will first want to read about the Namada blockchain, which is the first project in the anoma ecosystem and is the repo to which you contributed:
Website: https://namada.net/
Namada docs: https://docs.namada.net/
Namada specs: https://specs.namada.net/

Anoma itself is a more long-term project that we are also working on. Some resources are:
Website: https://anoma.net/
Anoma research: https://research.anoma.net/
At some point in the near future, the specs for anoma (specs.anoma.net) will be back online.

@DoTheBestToGetTheBest
Copy link
Contributor Author

@Fraccaman hey is there a reason for closing this ?

It was accidental. Thanks for the contribution, this will be merged soon after I clean it up a bit.

thank you for your answer, i made another pr which was closed too( i don't know why too)

Feel free to let me know which one it is, but in general since announcing the airdrop we have received lots of spammy PRs that contribute very little and may appear to be attempts at airdrop farming, so we have been closing lots of them. We do want to merge legitimate attempts at contributing to the repo though.

it was this pr : #2333
don't worry, i'm not looking to get the airdrop :)
i'm starting to learn about namada and trying to contribute on it while learning it :)
would be greats also to join a telegram or something where namada devs discuss :)

Awesome to hear! There is an active discord channel with several pages for devs and testnet usage. You should check them out and try using the latest testnets :). https://discord.com/invite/namada

also what do you suggest for me documentation to know like everything about anoma please? how the chain works, transactions type here, consesus, etc etc

You will first want to read about the Namada blockchain, which is the first project in the anoma ecosystem and is the repo to which you contributed: Website: https://namada.net/ Namada docs: https://docs.namada.net/ Namada specs: https://specs.namada.net/

Anoma itself is a more long-term project that we are also working on. Some resources are: Website: https://anoma.net/ Anoma research: https://research.anoma.net/ At some point in the near future, the specs for anoma (specs.anoma.net) will be back online.

Thank you so so much ! Really appreciate. Ty!

@brentstone brentstone self-requested a review December 28, 2023 00:35
Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brentstone brentstone merged commit b4de06a into anoma:main Dec 28, 2023
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants