Removes the hardcoded masp sentinel key #2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grarco
force-pushed
the
grarco/remove-masp-key
branch
from
598e913 to
e2ffafe
Compare
murisi
approved these changes
Jan 12, 2024
Closed
tzemanovic
added a commit
that referenced
this pull request
Jan 12, 2024
* origin/grarco/remove-masp-key: Changelog #2376 Removes the hardcoded masp sentinel key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removes the hardcoded masp key from the codebase. Updates
tx_signersto return an empty vector of keys if the source of the tx is MASP since there's no need to sign the tx in that case.Indicate on which release or other PRs this topic is based on
v0.29.0
Checklist before merging to
draft