Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance misc refactors #2377

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Governance misc refactors #2377

merged 3 commits into from
Jan 13, 2024

Conversation

grarco
Copy link
Collaborator

@grarco grarco commented Jan 10, 2024

Describe your changes

Shared function to compute the total power that voted on a governance proposal.
Modifies bad naming on a local variable when displaying the result of a proposal

Indicate on which release or other PRs this topic is based on

v0.29.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@grarco grarco marked this pull request as ready for review January 10, 2024 18:27
@grarco grarco requested a review from cwgoes January 10, 2024 18:28
Copy link
Collaborator

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@grarco grarco mentioned this pull request Jan 11, 2024
brentstone added a commit that referenced this pull request Jan 11, 2024
* grarco/governance-cleanup:
  Changelog #2377
  Shared function for governance total voted power
  Nit renames variable in `ProposalResult` display
@brentstone brentstone merged commit ffc8bca into main Jan 13, 2024
12 of 15 checks passed
@brentstone brentstone deleted the grarco/governance-cleanup branch January 13, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants