Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

host env VP write check #240

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jul 29, 2022

to make sure that we're checking VPs written to storage in txs, the tx_write host function should disallow direct raw-bytes updates of VP storage keys. Instead, there's tx_update_validity_predicate that performs some validation on the VP code

tzemanovic added a commit that referenced this pull request Jul 29, 2022
shared/src/vm/host_env.rs Outdated Show resolved Hide resolved
@tzemanovic tzemanovic force-pushed the tomas+brentstone/host-env-vp-write-check branch from 6618fe8 to 4f8c283 Compare August 17, 2022 05:48
@tzemanovic tzemanovic marked this pull request as ready for review August 17, 2022 05:49
tzemanovic added a commit that referenced this pull request Aug 17, 2022
* tomas+brentstone/host-env-vp-write-check:
  changelog: add #240
  vm/host_env: disallow raw byte updates of validity predicates
This was referenced Aug 17, 2022
@tzemanovic tzemanovic added this to the v0.8.0 milestone Oct 11, 2022
@juped juped merged commit 40ec445 into main Oct 13, 2022
@juped juped deleted the tomas+brentstone/host-env-vp-write-check branch October 13, 2022 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants