Murisi/masp test vectors rebased #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murisi
force-pushed
the
murisi/masp-test-vectors-rebased
branch
from
b1b8004 to
6bd7968
Compare
Closed
murisi
force-pushed
the
murisi/masp-test-vectors-rebased
branch
from
6bd7968 to
3a3cd92
Compare
tzemanovic
added a commit
that referenced
this pull request
Jan 23, 2024
* origin/murisi/masp-test-vectors-rebased: Added changelog entry. Reified the pre-image of AssetTypes. Hashed the token denomination into AssetTypes to tighten HW wallet signing. Constrained the range of MASP test vectors generated for correctness. Now generating binding test vectors binding signatures correctly. Increased usage of prop_oneof macro. Now generating arbitrary ShieldedTransfer.
tzemanovic
added a commit
that referenced
this pull request
Jan 23, 2024
tzemanovic
added a commit
that referenced
this pull request
Jan 24, 2024
grarco
approved these changes
Jan 24, 2024
Closed
tzemanovic
added a commit
that referenced
this pull request
Jan 25, 2024
* origin/murisi/masp-test-vectors-rebased: Added changelog entry. Reified the pre-image of AssetTypes. Hashed the token denomination into AssetTypes to tighten HW wallet signing. Constrained the range of MASP test vectors generated for correctness. Now generating binding test vectors binding signatures correctly. Increased usage of prop_oneof macro. Now generating arbitrary ShieldedTransfer.
tzemanovic
added a commit
that referenced
this pull request
Jan 25, 2024
tzemanovic
added a commit
that referenced
this pull request
Jan 25, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Implemented the random generation of MASP test vectors and slightly altered MASP-related transaction sections to facilitate the printing of shielded amounts with correct denominations. More specifically, the changes are as follows:
TxProverto aid constructing these transactions with the following properties:LocalTxProversince it does not generate any zero-knowledge proofsMockTxProversince it generates binding signatures that the hardware wallet will checkAssetTypederivation to be parameterized by a token'stoken::DenominationMaspTxBuildersupplied to hardware wallets to includetoken::Denominationin the preimagesIndicate on which release or other PRs this topic is based on
Namada v0.30.1
Checklist before merging to
draft