Reworks the way the ledger waits for genesis start. #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lly initializes the node and outputs logs before sleeping until genesis start time
Fraccaman
reviewed
Feb 1, 2024
| @@ -168,7 +168,7 @@ test-e2e: | |||
| NAMADA_E2E_USE_PREBUILT_BINARIES=$(NAMADA_E2E_USE_PREBUILT_BINARIES) \ | |||
| NAMADA_E2E_DEBUG=$(NAMADA_E2E_DEBUG) \ | |||
| RUST_BACKTRACE=$(RUST_BACKTRACE) \ | |||
| $(cargo) +$(nightly) test e2e::$(TEST_FILTER) \ | |||
| $(cargo) +$(nightly) test $(jobs) e2e::$(TEST_FILTER) \ | |||
There was a problem hiding this comment.
e2e test must not run in parallel I think
There was a problem hiding this comment.
That only controls how many threads are used to build the tests, not for running them
Closed
sug0
approved these changes
Feb 1, 2024
brentstone
added a commit
that referenced
this pull request
Feb 1, 2024
* bat/feat/wait-for-genesis-logs: [chore]: Add changelog [feat]: Reworks the way the ledger waits for genesis start. It now fully initializes the node and outputs logs before sleeping until genesis start time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2495
Describe your changes
It now fully initializes the node and outputs logs before sleeping until genesis start time. Previously it would not start any processes until genesis times, giving no feedback to users until genesis time was reached.
Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft