Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft non-breaking + modularization #2692

Closed
wants to merge 95 commits into from
Closed

Conversation

murisi and others added 30 commits January 31, 2024 10:32
This includes the additional data required to fully review a proposal
when using `namada client query-proposal`:

- Default (optional hash of WASM code)
- PGF Steward (add/remove addresses)
- PGF Payment (actions)

Fixes #2570.
Show help for query-proposal-votes subcommand instead of crashing when no arg provided

Signed-off-by: Hyung-Kyu Choi <hyungkyu.choi@gmail.com>
Signed-off-by: Hyung-Kyu Choi <hyungkyu.choi@gmail.com>
* tomas/refactor-finalize-block:
  changelog: add #2482
  refactor finalize_block PoS updates
  refactor finalize_block governance updates
  refactor finalize_block token updates
* tomas/refactor-token:
  changelog: add #2493
  benches: fix the shell to update conversions on new epochs
  move shielded params from core into shielded_token
  move inflation from core to trans_token
  replace namada_state usage with namada_storage in token crates
* tomas/core-refactor:
  changelog: add #2503
  update all core types usages
  core: flatten types mod
  update replay_protection usage
  core: factor out the ledger::replay_protection mod into a new crate
  core: refactor out ledger::eth_bridge mod
* tomas/gov-refactor:
  changelog: add #2506
  gov: replace namada_state dep with namada_storage
* tomas/refactor-testing-addrs:
  changelog: add #2507
  core: prevent from using addresses for testing in non-test code
* tomas/refactor-state:
  changelog: add #2606
  benches: update for new state API
  test/wasm: update for new state API
  tests: update for new state API
  test/PoS: update for new state API
  apps: update for new state API
  namada: update for new state API, refactor tx and VP host envs
  sdk: update for new state API
  eth_bridge: update for new state API
  ibc: update for new state API
  state: refactor everything
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 847 lines in your changes are missing coverage. Please review.

Comparison is base (9181fbe) 53.38% compared to head (49f70a0) 53.06%.
Report is 10 commits behind head on main.

Files Patch % Lines
crates/apps/src/lib/cli.rs 0.00% 130 Missing ⚠️
crates/ibc/src/actions.rs 0.00% 107 Missing ⚠️
crates/apps/src/lib/client/masp.rs 0.00% 97 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 75 Missing ⚠️
crates/governance/src/storage/proposal.rs 0.00% 51 Missing ⚠️
crates/core/src/event.rs 47.87% 49 Missing ⚠️
crates/apps/src/lib/cli/client.rs 0.00% 42 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs 0.00% 42 Missing ⚠️
crates/apps/src/lib/client/rpc.rs 0.00% 39 Missing ⚠️
crates/apps/src/lib/node/ledger/shell/mod.rs 79.36% 26 Missing ⚠️
... and 32 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2692      +/-   ##
==========================================
- Coverage   53.38%   53.06%   -0.33%     
==========================================
  Files         302      308       +6     
  Lines      103398   103719     +321     
==========================================
- Hits        55203    55035     -168     
- Misses      48195    48684     +489     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants