-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft non-breaking + modularization #2692
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e with consesus key in wallet.toml
This includes the additional data required to fully review a proposal when using `namada client query-proposal`: - Default (optional hash of WASM code) - PGF Steward (add/remove addresses) - PGF Payment (actions) Fixes #2570.
Show help for query-proposal-votes subcommand instead of crashing when no arg provided Signed-off-by: Hyung-Kyu Choi <hyungkyu.choi@gmail.com>
Signed-off-by: Hyung-Kyu Choi <hyungkyu.choi@gmail.com>
* tomas/refactor-finalize-block: changelog: add #2482 refactor finalize_block PoS updates refactor finalize_block governance updates refactor finalize_block token updates
* tomas/refactor-token: changelog: add #2493 benches: fix the shell to update conversions on new epochs move shielded params from core into shielded_token move inflation from core to trans_token replace namada_state usage with namada_storage in token crates
* tomas/core-refactor: changelog: add #2503 update all core types usages core: flatten types mod update replay_protection usage core: factor out the ledger::replay_protection mod into a new crate core: refactor out ledger::eth_bridge mod
* tomas/gov-refactor: changelog: add #2506 gov: replace namada_state dep with namada_storage
* tomas/refactor-testing-addrs: changelog: add #2507 core: prevent from using addresses for testing in non-test code
* tomas/refactor-state: changelog: add #2606 benches: update for new state API test/wasm: update for new state API tests: update for new state API test/PoS: update for new state API apps: update for new state API namada: update for new state API, refactor tx and VP host envs sdk: update for new state API eth_bridge: update for new state API ibc: update for new state API state: refactor everything
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2692 +/- ##
==========================================
- Coverage 53.38% 53.06% -0.33%
==========================================
Files 302 308 +6
Lines 103398 103719 +321
==========================================
- Hits 55203 55035 -168
- Misses 48195 48684 +489 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: ☠️ do not merge this branch into your development branches and do not rely on it being stable. ☠️
contains: