Cleans up ferveo #3241
Merged
Cleans up ferveo #3241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grarco
force-pushed
the
grarco/ferveo-cleanup
branch
from
4389dd5 to
c6d20b0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3241 +/- ##
=======================================
Coverage 60.24% 60.25%
=======================================
Files 303 302 -1
Lines 93191 93181 -10
=======================================
+ Hits 56145 56146 +1
+ Misses 37046 37035 -11 ☔ View full report in Codecov by Sentry. |
batconjurer
requested changes
May 15, 2024
crates/tx/src/data/wrapper.rs
Outdated
| fn from_str(s: &str) -> Result<Self, Self::Err> { | ||
| Ok(Self(s.parse()?)) | ||
| impl WrapperTx { | ||
| /// Create a new wrapper tx from unencrypted tx, the personal keypair, |
There was a problem hiding this comment.
this doc comment is now out of date.
There was a problem hiding this comment.
Should be up to date now
batconjurer
approved these changes
May 16, 2024
brentstone
added a commit
that referenced
this pull request
May 16, 2024
* grarco/ferveo-cleanup: Updates wrapper tx constructor documentation Changelog #3241 Cleans up ferveo-related things
brentstone
added a commit
that referenced
this pull request
May 21, 2024
* origin/grarco/ferveo-cleanup: Updates wrapper tx constructor documentation Changelog #3241 Cleans up ferveo-related things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removes the references to ferveo
Indicate on which release or other PRs this topic is based on
v0.35.1
Checklist before merging to
draft