-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint dbg and prints #3257
Merged
Merged
lint dbg and prints #3257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3257 +/- ##
==========================================
+ Coverage 60.24% 60.26% +0.02%
==========================================
Files 303 303
Lines 93191 93453 +262
==========================================
+ Hits 56145 56323 +178
- Misses 37046 37130 +84 ☔ View full report in Codecov by Sentry. |
brentstone
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
brentstone
added a commit
that referenced
this pull request
May 16, 2024
* tomas/lint-dbg-and-prints: changelog: add #3257 fix lint warnings add lints for dbg and prints (except for in tests)
brentstone
added a commit
that referenced
this pull request
May 21, 2024
* origin/tomas/lint-dbg-and-prints: changelog: add #3257 fix lint warnings add lints for dbg and prints (except for in tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #3227
also fixes some rust 2018 idioms and missing docs
Indicate on which release or other PRs this topic is based on
#3214
diff: https://github.com/anoma/namada/pull/3257/files/860132bdfce5e91864bc07808610a39289bd2797..a1c534c52efcf0d8a2797a6f3b976ef6e831b7d2
Checklist before merging to
draft