Remove unused WASM memory export #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3258 +/- ##
==========================================
- Coverage 60.24% 60.23% -0.02%
==========================================
Files 303 303
Lines 93191 93183 -8
==========================================
- Hits 56145 56126 -19
- Misses 37046 37057 +11 ☔ View full report in Codecov by Sentry. |
tzemanovic
approved these changes
May 17, 2024
tzemanovic
added a commit
that referenced
this pull request
May 17, 2024
* origin/tiago/dont-export-wasm-mem: Changelog for #3258 Remove unused WASM memory export
brentstone
added a commit
that referenced
this pull request
May 17, 2024
* tiago/dont-export-wasm-mem: Changelog for #3258 Remove unused WASM memory export
brentstone
added a commit
that referenced
this pull request
May 21, 2024
* origin/tiago/dont-export-wasm-mem: Changelog for #3258 Remove unused WASM memory export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The wasm execution environment instantiated a block of memory that went unused by txs/vps. In this PR, we remove the code that instantiated that memory block.
Indicate on which release or other PRs this topic is based on
v0.35.1Checklist before merging to
draft