split up node lib code #3265
Merged
split up node lib code #3265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3265 +/- ##
==========================================
- Coverage 60.24% 53.98% -6.27%
==========================================
Files 303 315 +12
Lines 93191 105320 +12129
==========================================
+ Hits 56145 56857 +712
- Misses 37046 48463 +11417 ☔ View full report in Codecov by Sentry. |
* origin/grarco/masp-fees: Changelog #3217 Assigns issues to TODOs Removes `wrapper_changed_keys` from `TxResult` Removes fee unshielding e2e test Removes fee unshielding integration tests Recomputes tx test fixture Recomputes wasm for tests modules Updates TODO comments Reworks sdk fee validation Renames `wrapper_fee_check` Removes error/functions related to fee unshielding Removes `descriptions_limit` protocol param Removes redundandt wrapper types Removes fee unshielding cli and tx args Removes `unshield_section_hash` from `WrapperTx`. Updates the relative functions. Removes event for masp wrapper tx
tzemanovic
force-pushed
the
tomas/split-up-node
branch
from
bb4c198 to
4295161
Compare
tzemanovic
added a commit
that referenced
this pull request
May 21, 2024
* tomas/split-up-node: changelog: add #3265 post node split-up fixes `mv crates/node/src/mod.rs crates/node/src/lib.rs` `rm crates/node/src/lib.rs` `mv crates/apps_lib/src/bench_utils.rs crates/node/src/` `mv crates/node/src/tendermint_node.rs crates/apps_lib/src/` `mv crates/node/src/ledger/* crates/node/src/` `mv crates/node/src/mod.rs crates/node/src/lib.rs` `mv crates/apps_lib/src/node crates/node/src` node: add a new crate for node lib crate
Fraccaman
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
relates to #2111
Indicate on which release or other PRs this topic is based on
#3259
diff: https://github.com/anoma/namada/pull/3265/files/b132a3a30da1b60d61d1ed981408b363cb06244b..4295161be956f3238276fc48e8a938cc8cb89051
Checklist before merging to
draft