Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps update #4284

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

deps update #4284

wants to merge 18 commits into from

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Jan 29, 2025

Describe your changes

replaces #4212

Couple things left out for various reasons:

  • ledger-transport and ledger-transport-hid have to match ledger-namada-rs
  • rand and rand_core have to match ed25519-consensus and k256 which have not yet been updated
  • rocksdb to be done separately with updated CI pre-compile
  • all wasmer crates - possibly consensus breaking

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic mentioned this pull request Feb 3, 2025
3 tasks
@tzemanovic tzemanovic force-pushed the tomas/deps-update branch 3 times, most recently from 169e47e to c9a74f7 Compare February 7, 2025 14:55
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 62.79070% with 16 lines in your changes missing coverage. Please review.

Project coverage is 74.41%. Comparing base (3c423f9) to head (7e00782).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/node/src/lib.rs 0.00% 12 Missing ⚠️
crates/apps_lib/src/tendermint_node.rs 0.00% 2 Missing ⚠️
crates/sdk/src/args.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4284      +/-   ##
==========================================
+ Coverage   74.18%   74.41%   +0.22%     
==========================================
  Files         345      340       -5     
  Lines      110644   110216     -428     
==========================================
- Hits        82086    82020      -66     
+ Misses      28558    28196     -362     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic marked this pull request as ready for review February 13, 2025 12:06
@tzemanovic tzemanovic added non-breaking-change backport-libs-0.47 Backport libraries to 0.47 maintenance branch dependencies labels Feb 13, 2025
@tzemanovic tzemanovic requested a review from sug0 February 13, 2025 12:08
@sug0
Copy link
Collaborator

sug0 commented Feb 13, 2025

uhm ci is totally broken. is this expected?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-libs-0.47 Backport libraries to 0.47 maintenance branch dependencies non-breaking-change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants