Added the recovery id to secp256k signatures #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
reviewed
Oct 17, 2022
juped
force-pushed
the
bat/secp256k-recovery-id
branch
from
af87318 to
e19de01
Compare
|
rebased on v0.8.0, merged to new draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normal secp256k signatures produce two finite field values: r and s. For ethereum, to prevent malleability attacks (the signature r, -s is also valid if r,s is), a third value is given, the so-called recovery id. We will need this for producing signatures that can be verified on Ethereum.