Refactor Validator Sets #721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent/refactor-validator-sets
branch
from
685ad4b to
65c174a
Compare
…rmint 0.34 vs 0.37
brentstone
force-pushed
the
brent/refactor-validator-sets
branch
from
82cfb92 to
c674cd3
Compare
|
Is this PR still relevant? @brentstone |
Yes still relevant, held out on further development atm because future changes will now largely depend on #740, which is still yet to be completed. |
|
Closing this for now, since it's stale. @brentstone we still want this but it needs to rebased and then it can be reopened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As specified in #283, the validator sets should be refactored from
activeandinactivetoconsenses,below_capacity, andbelow_threshold. Theactiveandconsensusvalidator sets are the same (just renaming).The
inactivevalidator set is further refactored intobelow_capacityandbelow_threshold. The "threshold" refers to a level of bonded stake below which we do not iterate over the validators in various PoS actions. The goal is to prevent unbounded iteration over validator sets.Currently based on #714