Construct VampIRValidityPredicateCircuit using a vamp-ir file #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
paul/support-vampir-file
branch
from
5f86ab5
to
3584c44
Compare
paulcadman
force-pushed
the
paul/support-vampir-file
branch
from
3584c44
to
ad04585
Compare
Previously VampIRValidityPredicateCircuit was constucted from a Halo2 circuit file that was precompiled by vamp-ir. We can use the vamp-ir `compile` API to perform this step in directly in taiga instead. This change only affects the POC `test_create_vp_from_vamp_ir_file` test.
paulcadman
force-pushed
the
paul/support-vampir-file
branch
from
ad04585
to
384078c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small change to the
VampIRValidityPredicateCircuitimplementation to construct a circuit directly from a vamp-ir file.Previously VampIRValidityPredicateCircuit was constucted from a Halo2 circuit
file that was precompiled by vamp-ir. We can use the vamp-ir
compileAPIto perform this step in directly in taiga instead.
This change only affects the POC
test_create_vp_from_vamp_ir_filetest.Relates to:
#157
#151