Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve build warnings #260

Merged
merged 2 commits into from
Mar 23, 2024
Merged

Conversation

davidrusu
Copy link
Contributor

@davidrusu davidrusu commented Mar 23, 2024

On build, I see a lot of unused import warnings, e.g.

warning: unused import: `utils::read_base_field`
  --> taiga_halo2/src/circuit/vp_examples.rs:12:5
   |
12 |     utils::read_base_field,
   |     ^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

This PR simply pushes those imports into the Borsh serializer impls where they are used

(chains off of #259)

Copy link
Collaborator

@XuyangSong XuyangSong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. @davidrusu

@XuyangSong XuyangSong merged commit 7a81f34 into anoma:main Mar 23, 2024
3 of 4 checks passed
@davidrusu davidrusu deleted the resolve-build-warnings branch March 23, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants