Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad audio quality and missing notifications permission fixed, max camera frame rates refactoring #41

Merged
merged 3 commits into from
Sep 20, 2024

Conversation

s0llvan
Copy link
Contributor

@s0llvan s0llvan commented Sep 20, 2024

#29 fixed with the highest common audio quality, but as discussed, an option to select audio quality is to be foreseen later
#40 partially fixed (the notification does not appear at the first video capture)
#23 (like #39) need tests for 60 and 90 fps

@s0llvan s0llvan changed the title fixed: bad audio quality, missing notifications permission and refactor: use of CamcorderProfile instead of CameraCharacteristics Bad audio quality and missing notifications permission fixed, max camera frame rates refactoring Sep 20, 2024
@anonfaded
Copy link
Owner

Great work 😀
Will merge and test in some moments.

Btw i see your profile has only this repository as a fork and none others, curious to know the reason

@s0llvan
Copy link
Contributor Author

s0llvan commented Sep 20, 2024

Great work 😀 Will merge and test in some moments.

Btw i see your profile has only this repository as a fork and none others, curious to know the reason

Thanks 😁

I created my account in august 😅 anothers forks coming soon !

@anonfaded
Copy link
Owner

Great work 😀 Will merge and test in some moments.

Btw i see your profile has only this repository as a fork and none others, curious to know the reason

Thanks 😁

I created my account in early September 😅 anothers forks coming soon !

So was this your first open source contribution?

Also can you share how you got to know about FadCam project? :)

@s0llvan
Copy link
Contributor Author

s0llvan commented Sep 20, 2024

Great work 😀 Will merge and test in some moments.
Btw i see your profile has only this repository as a fork and none others, curious to know the reason

Thanks 😁
I created my account in early September 😅 anothers forks coming soon !

So was this your first open source contribution?

Also can you share how you got to know about FadCam project? :)

By chance ^^, I was looking for a free app, without ads or trackers, to record trips, and I came across FadCam

Yes, this is my first open source contribution, but i'm developer (web) sinced many years.

@anonfaded
Copy link
Owner

Wow, good to know :)
Some users found it on YouTube where content creators featured this app. I didn't expect this much downloads so it all happened so fast and I'm happy that people liked it.

I did some basic web dev, and nowadays doing python for backend, also doing CTFs and learning cyber security as main. Android dev and java just happened very randomly lol

@s0llvan
Copy link
Contributor Author

s0llvan commented Sep 20, 2024

Wow, good to know :) Some users found it on YouTube where content creators featured this app. I didn't expect this much downloads so it all happened so fast and I'm happy that people liked it.

I did some basic web dev, and nowadays doing python for backend, also doing CTFs and learning cyber security as main. Android dev and java just happened very randomly lol

It's cool then, i also train in cybersecurity.
It's true there's already a lot of success for such a recent application 🙂

@anonfaded anonfaded merged commit d46e9fa into anonfaded:master Sep 20, 2024
@anonfaded
Copy link
Owner

Checked, seems fine. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants