Skip to content

Commit

Permalink
hack: Update controller-gen to v0.14.0
Browse files Browse the repository at this point in the history
Golang v1.22 doesn't work well[1] with any controller-gen < v0.14.0.
Updating controller-gen mandates removal of trivialVersions boolean
marker previously used for legacy v1beta1 CRDs[2].

[1] kubernetes-sigs/controller-tools#888 (comment)
[2] https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.7.0

Signed-off-by: Anoop C S <anoopcs@samba.org>
  • Loading branch information
anoopcs9 committed Apr 24, 2024
1 parent 5b98317 commit 16d9c54
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ TAG?=latest
IMG?=quay.io/samba.org/samba-operator:$(TAG)

# Produce CRDs that work on Kubernetes 1.16 or later
CRD_OPTIONS?="crd:trivialVersions=true,crdVersions=v1"
CRD_OPTIONS?="crd:crdVersions=v1"

CHECK_GOFMT_FLAGS?=-e -s -l

Expand Down
2 changes: 1 addition & 1 deletion hack/install-tools.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ _install_kustomize() {
}

_install_controller_gen() {
_install_tool sigs.k8s.io/controller-tools/cmd/controller-gen@v0.6.2
_install_tool sigs.k8s.io/controller-tools/cmd/controller-gen@v0.14.0
}

_install_revive() {
Expand Down

0 comments on commit 16d9c54

Please sign in to comment.