Add benchmarks for csv crate #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thank you! I'll try to figure out why CircleCI isn't running for this ASAP. |
anp
reviewed
Oct 4, 2018
.gitignore
Outdated
| @@ -6,3 +6,4 @@ vendor/ | |||
| site.retry | |||
| .ansible-vault-password | |||
| rust.git | |||
| .idea/ | |||
There was a problem hiding this comment.
Could you include this in your global gitignore? I'd prefer to keep the project gitignore focused on files our internal scripts will actually generate.
There was a problem hiding this comment.
Thanks, didn't know that was a thing. Fixed.
shssoichiro
force-pushed
the
add-csv-benches
branch
from
75c1401
to
7359cfd
Compare
|
Thanks so much! I'll get these running in the next couple of days :D. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #1. Saw the request for help in the recent blog post.