Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RunLoop::run_on_state_changes() shouldn't call run_once unless a state change occurred #215

Open
anp opened this issue Nov 26, 2020 · 0 comments
Open

RunLoop::run_on_state_changes() shouldn't call run_once unless a state change occurred #215

anp opened this issue Nov 26, 2020 · 0 comments
Labels
core Related to the core `moxie` crate
Milestone
moxie 1.0

Comments

@anp
Copy link
Owner

anp commented Nov 26, 2020

Right now run_on_state_changes only does the right thing if the RunLoop is the top-level task. If it's being joined with another future it might be re-run unnecessarily.

One option to fix this would be to wrap the state change waker in a layer that also notifies the RunLoop that a state change did occur. Maybe by adding a "state revision" field to the runtime and incrementing that on updates? Then we could make sure the state revision has advanced past the runtime revision when calling run_once.

I'm not sure whether the run skipping should be done in RunTime or RunLoop, I'm leaning towards the latter.
zetanumbers pushed a commit to zetanumbers/moxie that referenced this issue Nov 27, 2020
First try at fixing anp#215... 1 test fails
521141b
@zetanumbers zetanumbers mentioned this issue Nov 28, 2020
Closed
zetanumbers pushed a commit to zetanumbers/moxie that referenced this issue Nov 29, 2020
Fixed anp#215
f87b753
@zetanumbers zetanumbers mentioned this issue Dec 7, 2020
Open
zetanumbers pushed a commit to zetanumbers/moxie that referenced this issue Dec 14, 2020
Initial fix of anp#197 anp#215 anp#220 anp#222 for moxie crate
d6b5dde
@zetanumbers zetanumbers mentioned this issue Dec 14, 2020
Open
4 tasks
zetanumbers pushed a commit to zetanumbers/moxie that referenced this issue Dec 29, 2020
Initial fix of anp#197 anp#215 anp#220 anp#222 for moxie crate
657b3f8
zetanumbers pushed a commit to zetanumbers/moxie that referenced this issue Jan 3, 2021
Initial fix of anp#197 anp#215 anp#220 anp#222 for moxie crate
cc3ea85
zetanumbers pushed a commit to zetanumbers/moxie that referenced this issue Jan 5, 2021
Initial fix of anp#197 anp#215 anp#220 anp#222 for moxie crate
772c697
@anp anp added the core Related to the core `moxie` crate label Feb 2, 2021
@anp anp added this to the moxie 1.0 milestone Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Related to the core `moxie` crate
Projects
None yet
Milestone
moxie 1.0
Development

Successfully merging a pull request may close this issue.

Fix RunLoop behavior as an async Stream zetanumbers/moxie
1 participant
@anp