-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parking_lot -> simple_mutex #219
Conversation
Thanks for the PR! I'm looking into the errors you ran into right now. Could you try making this change with |
How is your Rust toolchain installed? The repository is set up assuming you're using rustup which may not be correct. |
Re your question (2) I opened #221. There used to be a bunch more nightly deps and I think that might be the only one left! Re (1), can you paste the output of |
My first attempt was with fn lock(&self) -> LockResult<MutexGuard<'_, T>> // std
fn lock(&self) -> MutexGuard<T> // simple-mutex
fn lock(&self) -> MutexGuard<'_, R, T> // parking_lot As the result, I had to write a lot of
I've installed Rust from the official
I've just tried the current one (
I've done some more investigation and the reason why you can't reproduce it is Ok, back to the problem. There is probably a bug or changed API in the latest paste crate Let's look at the code in Lines 76 to 88 in 74fb3e7
I've tried to replace |
Thank you again for this! I think for now it'll be easier to take the approach proposed in #225 so I'll give this a close.
I'm not sure I follow where this error is coming from, if you're still hitting it can you open a separate issue? Would be happy to help figure it out. |
Resolves #218
This PR replaces the dependency parking_lot with simple_mutex to resolve runtime bugs caused by
parking_lot
'sMutex::lock
in Wasm. See the linked issue for more info.The fix has been manually tested through a Seed app that uses
topo
as an indirect dependency.The PR has been marked as
Draft
because of two reasons:main
branch without my changes:How should I resolve it?
topo
) on the stable Rust is this line inCargo.toml
:Is there a simple way to remove this limitation?
Thank you!