add vm console tests, fix console model

ans-group · Apr 3, 2020 · fa73b2c · fa73b2c
1 parent 77b530d
commit fa73b2c
Show file tree

Hide file tree

Showing 2 changed files with 83 additions and 1 deletion.
diff --git a/pkg/service/ecloud/model.go b/pkg/service/ecloud/model.go
@@ -294,5 +294,5 @@ func (s TemplateType) String() string {
 
 // ConsoleSession represents an eCloud Virtual Machine console session
 type ConsoleSession struct {
-	URL int `json:"url"`
+	URL string `json:"url"`
 }
diff --git a/pkg/service/ecloud/service_virtualmachine_test.go b/pkg/service/ecloud/service_virtualmachine_test.go
@@ -1417,3 +1417,85 @@ func TestDeleteVirtualMachineTag(t *testing.T) {
 		assert.IsType(t, &TagNotFoundError{}, err)
 	})
 }
+
+func TestCreateVirtualMachineConsoleSession(t *testing.T) {
+	t.Run("Valid", func(t *testing.T) {
+		mockCtrl := gomock.NewController(t)
+		defer mockCtrl.Finish()
+
+		c := mocks.NewMockConnection(mockCtrl)
+
+		s := Service{
+			connection: c,
+		}
+
+		c.EXPECT().Put("/ecloud/v1/vms/123/console-session", nil).Return(&connection.APIResponse{
+			Response: &http.Response{
+				Body:       ioutil.NopCloser(bytes.NewReader([]byte("{\"data\":{\"url\":\"ukfast.co.uk\"}}"))),
+				StatusCode: 200,
+			},
+		}, nil).Times(1)
+
+		session, err := s.CreateVirtualMachineConsoleSession(123)
+
+		assert.Nil(t, err)
+		assert.Equal(t, "ukfast.co.uk", session.URL)
+	})
+
+	t.Run("InvalidVirtualMachineID_ReturnsError", func(t *testing.T) {
+		mockCtrl := gomock.NewController(t)
+		defer mockCtrl.Finish()
+
+		c := mocks.NewMockConnection(mockCtrl)
+
+		s := Service{
+			connection: c,
+		}
+
+		_, err := s.CreateVirtualMachineConsoleSession(0)
+
+		assert.NotNil(t, err)
+		assert.Equal(t, "invalid virtual machine id", err.Error())
+	})
+
+	t.Run("ConnectionError_ReturnsError", func(t *testing.T) {
+		mockCtrl := gomock.NewController(t)
+		defer mockCtrl.Finish()
+
+		c := mocks.NewMockConnection(mockCtrl)
+
+		s := Service{
+			connection: c,
+		}
+
+		c.EXPECT().Put("/ecloud/v1/vms/123/console-session", nil).Return(&connection.APIResponse{}, errors.New("test error 1")).Times(1)
+
+		_, err := s.CreateVirtualMachineConsoleSession(123)
+
+		assert.NotNil(t, err)
+		assert.Equal(t, "test error 1", err.Error())
+	})
+
+	t.Run("404_ReturnsVirtualMachineNotFoundError", func(t *testing.T) {
+		mockCtrl := gomock.NewController(t)
+		defer mockCtrl.Finish()
+
+		c := mocks.NewMockConnection(mockCtrl)
+
+		s := Service{
+			connection: c,
+		}
+
+		c.EXPECT().Put("/ecloud/v1/vms/123/console-session", nil).Return(&connection.APIResponse{
+			Response: &http.Response{
+				Body:       ioutil.NopCloser(bytes.NewReader([]byte(""))),
+				StatusCode: 404,
+			},
+		}, nil).Times(1)
+
+		_, err := s.CreateVirtualMachineConsoleSession(123)
+
+		assert.NotNil(t, err)
+		assert.IsType(t, &VirtualMachineNotFoundError{}, err)
+	})
+}