Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

solution difference es5 and es-next #147

Closed
wants to merge 1 commit into from

Conversation

II-alex-II
Copy link

Hi @anseki,
Take the MR, it makes the difference es5 and es-next minimal.
It works

@anseki
Copy link
Owner

anseki commented Jul 28, 2020

Hi @II-alex-II, thank you for the PR.
Could you publish type definition on DefinitelyTyped?
Thank you for your time. 😄

@anseki anseki closed this Jul 28, 2020
@II-alex-II
Copy link
Author

II-alex-II commented Jul 28, 2020

I can publish type definition on DefinitelyTyped,could you code add?
(function (global, factory) { typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() : typeof define === 'function' && define.amd ? define(factory) : (global['leader-line'] = factory()); }(this, (function () { return LeaderLine; })));

@anseki
Copy link
Owner

anseki commented Jul 28, 2020

LeaderLine is old now. You should've seen many legacy codes in the source code.
I think that the code should be rewritten for modern code, structure and mechanism before supporting importing if the library do that. (I think that replacing all of code may need time.)
Of course you can do that if you want.
I don't want to make the code be a mess before the rewriting.

@II-alex-II
Copy link
Author

Ok, I created alternative https://www.npmjs.com/package/leader-line-new and example use https://github.com/II-alex-II/react-leader-line, today I will move code all my PR

@anseki
Copy link
Owner

anseki commented Jul 28, 2020

Thank you! 😄

@II-alex-II
Copy link
Author

Thank you! You could help contribute to creating a new version?

@anseki
Copy link
Owner

anseki commented Jul 28, 2020

Yes, I will contribute that if I can.

@kirillku kirillku mentioned this pull request Feb 4, 2021
@BrianAKass
Copy link

Hey there passing through and spotted this library for a project im working on. Are you two still developing an update?

@anseki
Copy link
Owner

anseki commented Feb 12, 2021

Hi @BrianAKass, thank you for the comment.
We are not writing the type definition and module.

@BrianAKass
Copy link

Thanks I am using react-xarrows https://eliav2.github.io/react-xarrows/ in the meantime. Fits my needs so im good for now.

@anseki
Copy link
Owner

anseki commented Feb 12, 2021

😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants