Wrapped references around structs #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josevalim
reviewed
Jul 13, 2018
lib/tensorflex.ex
Outdated
|
|
||
| def load_nifs do | ||
| :erlang.load_nif("priv/Tensorflex", 0) | ||
| import Tensorflex.NIFs |
There was a problem hiding this comment.
You don't need to import them before using. import in Elixir is to invoke functions without the module name.
However, you could use aliases to avoid typing the Tensorflex. prefix everytime.
alias Tensorflex.{NIFs, Graph, Matrix, Tensor}Now you can write NIFs.read_graph(filepath) instead of Tensorflex.NIFs.read_graph(filepath)
There was a problem hiding this comment.
I understand. Thank you for the input.
I've added this and I'm merging the latest code.
|
I have added one comment, everything else is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@josevalim, I have wrapped the references around appropriate structs as you had instructed. Is this fine?
Once you give the go-ahead, I'll make more changes and start removing C code that can easily be replicated in Elixir.