Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vpc_route_table/test: tag missing on new public route #484

Closed
1 task done
goneri opened this issue Aug 31, 2021 · 3 comments
Closed
1 task done

ec2_vpc_route_table/test: tag missing on new public route #484

goneri opened this issue Aug 31, 2021 · 3 comments
Assignees
Labels
bug This issue/PR relates to a bug CI needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly

Comments

@goneri
Copy link
Member

goneri commented Aug 31, 2021

Summary

e.g: https://dashboard.zuul.ansible.com/t/ansible/build/d127b4b683634637a8ef32a48c08f0f0


TASK [ec2_vpc_route_table : create public route table] *************************
task path: /home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/ec2_vpc_route_table/tasks/main.yml:72
<testhost> ESTABLISH LOCAL CONNECTION FOR USER: zuul
<testhost> EXEC /bin/sh -c 'echo ~zuul && sleep 0'
<testhost> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /home/zuul/.ansible/tmp `"&& mkdir "` echo /home/zuul/.ansible/tmp/ansible-tmp-1630355617.2544136-10839-248237670635474 `" && echo ansible-tmp-1630355617.2544136-10839-248237670635474="` echo /home/zuul/.ansible/tmp/ansible-tmp-1630355617.2544136-10839-248237670635474 `" ) && sleep 0'
Using module file /home/zuul/.ansible/collections/ansible_collections/amazon/aws/plugins/modules/ec2_vpc_route_table.py
<testhost> PUT /home/zuul/.ansible/tmp/ansible-local-10558yx6z893o/tmpb9gxf0dg TO /home/zuul/.ansible/tmp/ansible-tmp-1630355617.2544136-10839-248237670635474/AnsiballZ_ec2_vpc_route_table.py
<testhost> EXEC /bin/sh -c 'chmod u+x /home/zuul/.ansible/tmp/ansible-tmp-1630355617.2544136-10839-248237670635474/ /home/zuul/.ansible/tmp/ansible-tmp-1630355617.2544136-10839-248237670635474/AnsiballZ_ec2_vpc_route_table.py && sleep 0'
<testhost> EXEC /bin/sh -c 'ANSIBLE_DEBUG_BOTOCORE_LOGS=True /home/zuul/venv/bin/python /home/zuul/.ansible/tmp/ansible-tmp-1630355617.2544136-10839-248237670635474/AnsiballZ_ec2_vpc_route_table.py && sleep 0'
<testhost> EXEC /bin/sh -c 'rm -f -r /home/zuul/.ansible/tmp/ansible-tmp-1630355617.2544136-10839-248237670635474/ > /dev/null 2>&1 && sleep 0'
changed: [testhost] => {
    "changed": true,
    "invocation": {
        "module_args": {
            "aws_access_key": "ASIA6CCDWXDOILL6GPV3",
            "aws_ca_bundle": null,
            "aws_config": null,
            "aws_secret_key": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "debug_botocore_endpoint_logs": true,
            "ec2_url": null,
            "lookup": "tag",
            "profile": null,
            "propagating_vgw_ids": null,
            "purge_routes": true,
            "purge_subnets": true,
            "purge_tags": false,
            "region": "us-east-1",
            "route_table_id": null,
            "routes": [],
            "security_token": "VALUE_SPECIFIED_IN_NO_LOG_PARAMETER",
            "state": "present",
            "subnets": null,
            "tags": {
                "Name": "Public route table",
                "Public": "true"
            },
            "validate_certs": true,
            "vpc_id": "vpc-01136da2cfa6e9004"
        }
    },
    "resource_actions": [
        "ec2:CreateRouteTable",
        "ec2:DescribeTags",
        "ec2:DescribeRouteTables",
        "ec2:CreateTags"
    ],
    "route_table": {
        "associations": [],
        "id": "rtb-04a805a2c772a51f8",
        "owner_id": "966509639900",
        "propagating_vgws": [],
        "route_table_id": "rtb-04a805a2c772a51f8",
        "routes": [
            {
                "destination_cidr_block": "10.228.228.0/22",
                "gateway_id": "local",
                "origin": "CreateRouteTable",
                "state": "active"
            }
        ],
        "tags": {},
        "vpc_id": "vpc-01136da2cfa6e9004"
    }
}

TASK [ec2_vpc_route_table : assert that public route table has an id] **********
task path: /home/zuul/.ansible/collections/ansible_collections/amazon/aws/tests/integration/targets/ec2_vpc_route_table/tasks/main.yml:79
fatal: [testhost]: FAILED! => {
    "assertion": "'Public' in create_public_table.route_table.tags and create_public_table.route_table.tags['Public'] == 'true'",
    "changed": false,
    "evaluated_to": false,
    "msg": "Assertion failed"
}

Issue Type

CI Bug Report

CI Jobs

https://dashboard.zuul.ansible.com/t/ansible/build/d127b4b683634637a8ef32a48c08f0f0

Pull Request

#456

Additional Information

No response

Code of Conduct

  • I agree to follow the Ansible Code of Conduct
@goneri goneri added the CI label Aug 31, 2021
@goneri goneri changed the title ec2_vpc_route_table/test: "assert that public route table has an id" failure ec2_vpc_route_table/test: tag missing on new public route Aug 31, 2021
@goneri
Copy link
Member Author

goneri commented Aug 31, 2021

FTR, last tag related change was: ansible-collections/community.aws#616

@ansibullbot
Copy link

@goneri: Greetings! Thanks for taking the time to open this issue. In order for the community to handle your issue effectively, we need a bit more information.

Here are the items we could not find in your description:

  • ansible version
  • component name

Please set the description of this issue with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/ISSUE_TEMPLATE/bug_report.md

click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly labels Aug 31, 2021
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 3, 2021
* Move regex definitions from global to calling function
* Remove unused regex
* Tidy up comments
* Replace json_query uses in tests with jinja selectattr
* Additional assertions in integration tests

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@721fad0
@alinabuzachis alinabuzachis self-assigned this Oct 4, 2021
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
* Move regex definitions from global to calling function
* Remove unused regex
* Tidy up comments
* Replace json_query uses in tests with jinja selectattr
* Additional assertions in integration tests
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Sep 18, 2023
* Move regex definitions from global to calling function
* Remove unused regex
* Tidy up comments
* Replace json_query uses in tests with jinja selectattr
* Additional assertions in integration tests
abikouo pushed a commit to abikouo/amazon.aws that referenced this issue Oct 24, 2023
* Move regex definitions from global to calling function
* Remove unused regex
* Tidy up comments
* Replace json_query uses in tests with jinja selectattr
* Additional assertions in integration tests
@GomathiselviS
Copy link
Collaborator

It appears that this issue has been resolved in the recent release. If you believe otherwise, please feel free to reopen the issue. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug CI needs_info This issue requires further information. Please answer any outstanding questions needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly
Projects
None yet
Development

No branches or pull requests

4 participants