-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR #1163/e3da3d50 backport][stable-5] expand module_utils.transformation unit tests #1164
Merged
softwarefactory-project-zuul
merged 1 commit into
stable-5
from
patchback/backports/stable-5/e3da3d50deb755cc41bf628feeea28352b6ddc1b/pr-1163
Oct 13, 2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
This issue/PR relates to a bug
community_review
module_utils
module_utils
needs_triage
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
tests
tests
labels
Oct 12, 2022
This comment was marked as resolved.
This comment was marked as resolved.
expand module_utils.transformation unit tests SUMMARY Expands the module_utils.transformation unit tests ensure that map_complex_type still returns transformed items if items exists that are not in the type_map. ISSUE TYPE Bugfix Pull Request Feature Pull Request COMPONENT NAME plugins/module_utils/transformation.py ADDITIONAL INFORMATION Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> (cherry picked from commit e3da3d5)
tremble
force-pushed
the
patchback/backports/stable-5/e3da3d50deb755cc41bf628feeea28352b6ddc1b/pr-1163
branch
from
October 13, 2022 07:35
ba7fa78
to
c7e47a7
Compare
tremble
approved these changes
Oct 13, 2022
softwarefactory-project-zuul
bot
deleted the
patchback/backports/stable-5/e3da3d50deb755cc41bf628feeea28352b6ddc1b/pr-1163
branch
October 13, 2022 08:23
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…sible-collections#1164) ec2_metric_alarm - drop deprecated support for symbolic operators SUMMARY With the migration to boto3 symbolic operators were deprecated. Remove it. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_metric_alarm ADDITIONAL INFORMATION See also: ansible/ansible#62669 Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…sible-collections#1164) ec2_metric_alarm - drop deprecated support for symbolic operators SUMMARY With the migration to boto3 symbolic operators were deprecated. Remove it. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_metric_alarm ADDITIONAL INFORMATION See also: ansible/ansible#62669 Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…sible-collections#1164) ec2_metric_alarm - drop deprecated support for symbolic operators SUMMARY With the migration to boto3 symbolic operators were deprecated. Remove it. ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_metric_alarm ADDITIONAL INFORMATION See also: ansible/ansible#62669 Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
This issue/PR relates to a bug
community_review
mergeit
Merge the PR (SoftwareFactory)
module_utils
module_utils
needs_triage
new_contributor
Help guide this first time contributor
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1163 as merged into main (e3da3d5).
SUMMARY
Expands the module_utils.transformation unit tests
ensure that
map_complex_type
still returns transformed items if items exists that are not in the type_map.ISSUE TYPE
COMPONENT NAME
plugins/module_utils/transformation.py
ADDITIONAL INFORMATION