Add retries on the same failures as AWSRetry for the waiters #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
force-pushed
the
waiters/retry_ratelimit
branch
from
63824c5
to
40370d9
Compare
tremble
force-pushed
the
waiters/retry_ratelimit
branch
from
40370d9
to
23f0650
Compare
|
I've made it through half of the community.aws tests for modules with waiters with no issues so far |
tremble
force-pushed
the
waiters/retry_ratelimit
branch
from
8a29adb
to
51da5b1
Compare
tremble
changed the title
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
* Prepare 1.1.0 release Run add_docs.py Run antsibull-changelog Bump release in galaxy.yml Update meta/runtime.yml with supported ansible revs Add requirements file to support execution environments Update amazon.aws rev in test requirements * Cleanup changelog formatting for new, sticter antsibull-changelog formatting Rerun add_docs.py with --branch-name flag Correct required amazon.aws revision to match the current in-progress release * add_docs generated bad markup, fix that This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@e95fb90
alinabuzachis
pushed a commit
to alinabuzachis/amazon.aws
that referenced
this pull request
Sep 9, 2022
* Prepare 1.1.0 release Run add_docs.py Run antsibull-changelog Bump release in galaxy.yml Update meta/runtime.yml with supported ansible revs Add requirements file to support execution environments Update amazon.aws rev in test requirements * Cleanup changelog formatting for new, sticter antsibull-changelog formatting Rerun add_docs.py with --branch-name flag Correct required amazon.aws revision to match the current in-progress release * add_docs generated bad markup, fix that This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@e95fb90
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
* Prepare 1.1.0 release Run add_docs.py Run antsibull-changelog Bump release in galaxy.yml Update meta/runtime.yml with supported ansible revs Add requirements file to support execution environments Update amazon.aws rev in test requirements * Cleanup changelog formatting for new, sticter antsibull-changelog formatting Rerun add_docs.py with --branch-name flag Correct required amazon.aws revision to match the current in-progress release * add_docs generated bad markup, fix that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Try getting our waiters to retry on the usual ratelimiting errors
ISSUE TYPE
COMPONENT NAME
plugins/module_utils/waiters.py
ADDITIONAL INFORMATION