s3_bucket_info - add support for bucket versioning in bucket_facts #1919
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 14s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 16s |
abikouo
force-pushed
the
s3_bucket_info_versioning
branch
from
16d1e2f
to
6f537ac
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 44s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 08s |
abikouo
force-pushed
the
s3_bucket_info_versioning
branch
from
021fd81
to
6af5a41
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 52s |
abikouo
force-pushed
the
s3_bucket_info_versioning
branch
from
6af5a41
to
d27de74
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 3m 54s |
| @@ -64,6 +66,8 @@ | |||
| - item.bucket_tagging["lowercase spaced"] == 'hello cruel world' | |||
| - item.bucket_tagging["Title Case"] == 'Hello Cruel World' | |||
| - item.bucket_location.LocationConstraint == aws_region | |||
| - item.bucket_versioning.Status is defined | |||
There was a problem hiding this comment.
Should we check for the value?
There was a problem hiding this comment.
@GomathiselviS for this specific test case I am just checking if the user request for the versioning information it is part of the ansible response, I don't want to check whether the versioning is enabled or not
There was a problem hiding this comment.
Could you please clarify why not? The task's name indicates "Assert that retrieved bucket facts contain valid data," and it verifies the values of other parameters. Wouldn't it be appropriate to also verify the value of bucket_versioning parameter?
There was a problem hiding this comment.
@GomathiselviS I have added an extra validation to ensure that the versioning is enabled
Co-authored-by: GomathiselviS <gomathiselvi@gmail.com>
abikouo
force-pushed
the
s3_bucket_info_versioning
branch
from
bee12d9
to
a943627
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 11s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 9m 00s |
softwarefactory-project-zuul
bot
merged commit 8ab86dd
into
ansible-collections:main
Backport to stable-7: cherry-pick succeededBackport PR branch: PR branch created, proceeding with making a PR. 🤖 @patchback |
…1919) s3_bucket_info - add support for bucket versioning in bucket_facts SUMMARY Module s3_bucket_info should be able to return the bucket versioning into bucket_facts ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket_info ADDITIONAL INFORMATION - amazon.aws.s3_bucket_info: name: mybucket bucket_facts: bucket_versioninig: true expecting output { "bucket_name": "mybucket", "buckets": [ { "bucket_versioning": {"Status": "Enabled"}, ## New information in output "creation_date": "2023-12-11T15:48:42+00:00", "name": "mybucket" } ], "changed": false, "msg": "Retrieved s3 info." } Reviewed-by: Alina Buzachis Reviewed-by: GomathiselviS Reviewed-by: Bikouo Aubin Reviewed-by: Helen Bailey <hebailey@redhat.com> (cherry picked from commit 8ab86dd)
tremble
added
backport-7
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #1946 🤖 @patchback |
…1919) s3_bucket_info - add support for bucket versioning in bucket_facts SUMMARY Module s3_bucket_info should be able to return the bucket versioning into bucket_facts ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket_info ADDITIONAL INFORMATION - amazon.aws.s3_bucket_info: name: mybucket bucket_facts: bucket_versioninig: true expecting output { "bucket_name": "mybucket", "buckets": [ { "bucket_versioning": {"Status": "Enabled"}, ## New information in output "creation_date": "2023-12-11T15:48:42+00:00", "name": "mybucket" } ], "changed": false, "msg": "Retrieved s3 info." } Reviewed-by: Alina Buzachis Reviewed-by: GomathiselviS Reviewed-by: Bikouo Aubin Reviewed-by: Helen Bailey <hebailey@redhat.com> (cherry picked from commit 8ab86dd)
…1919) (#1946) [PR #1919/8ab86dd0 backport][stable-7] s3_bucket_info - add support for bucket versioning in bucket_facts This is a backport of PR #1919 as merged into main (8ab86dd). SUMMARY Module s3_bucket_info should be able to return the bucket versioning into bucket_facts ISSUE TYPE Feature Pull Request COMPONENT NAME s3_bucket_info ADDITIONAL INFORMATION - amazon.aws.s3_bucket_info: name: mybucket bucket_facts: bucket_versioninig: true expecting output { "bucket_name": "mybucket", "buckets": [ { "bucket_versioning": {"Status": "Enabled"}, ## New information in output "creation_date": "2023-12-11T15:48:42+00:00", "name": "mybucket" } ], "changed": false, "msg": "Retrieved s3 info." } Reviewed-by: Mark Chappell
SUMMARY
Module
s3_bucket_infoshould be able to return the bucket versioning into bucket_factsISSUE TYPE
COMPONENT NAME
s3_bucket_infoADDITIONAL INFORMATION
expecting output
{ "bucket_name": "mybucket", "buckets": [ { "bucket_versioning": {"Status": "Enabled"}, ## New information in output "creation_date": "2023-12-11T15:48:42+00:00", "name": "mybucket" } ], "changed": false, "msg": "Retrieved s3 info." }