Test ruff #2070
Test ruff #2070
Conversation
alinabuzachis
force-pushed
the
test_ruff
branch
from
ab5d8f9
to
2a5bb88
Compare
GomathiselviS
requested review from
a team,
gravesm,
jillr,
hakbailey,
GomathiselviS and
abikouo
and removed request for
a team,
gravesm,
jillr,
hakbailey,
GomathiselviS and
abikouo
|
Build failed.
|
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
| @@ -292,7 +289,7 @@ def normalize_ec2_vpc_dhcp_config(option_config): | |||
| "netbios-name-servers": ["10.0.0.1", "10.0.1.1"], | |||
| "netbios-node-type": "1", | |||
| "ntp-servers": ["10.0.0.2", "10.0.1.2"] | |||
| }, | |||
| },. | |||
There was a problem hiding this comment.
We should probably remove the , here and lin 284 rather than adding a .
| @@ -203,12 +201,11 @@ def wait_for_status(self, elb_arn): | |||
|
|
|||
| def wait_for_deletion(self, elb_arn): | |||
| """ | |||
| Wait for load balancer to reach 'active' status | |||
| Wait for load balancer to reach 'active' status. | |||
There was a problem hiding this comment.
| Wait for load balancer to reach 'active' status. | |
| Wait for load balancer to reach 'deleted' status. |
| @@ -77,7 +75,7 @@ def _hashable_policy(policy, policy_list): | |||
| ('Effect', ('Allow',)), | |||
| ('Principal', ('AWS', (('arn:aws:iam::XXXXXXXXXXXX:user/username1',), ('arn:aws:iam::XXXXXXXXXXXX:user/username2',)))), | |||
| ('Resource', ('arn:aws:s3:::test_policy/*',)), ('Sid', ('AddCannedAcl2',)))), | |||
| ('Version', ('2012-10-17',)))] | |||
| ('Version', ('2012-10-17',)))]. | |||
There was a problem hiding this comment.
This is code, we don't want an arbitrary extra . here...
| @@ -52,9 +52,8 @@ def boto3_tag_list_to_ansible_dict(tags_list, tag_name_key_name=None, tag_value_ | |||
| Dict: Dict of key:value pairs representing AWS tags | |||
| { | |||
| 'MyTagKey': 'MyTagValue', | |||
| } | |||
| }. | |||
| @@ -68,9 +68,8 @@ def ansible_dict_to_boto3_filter_list(filters_dict): | |||
| 'i-01234567', | |||
| ] | |||
| } | |||
| ] | |||
| ]. | |||
| @@ -1311,9 +1311,8 @@ def build_network_spec(params): | |||
| ], | |||
| 'SecondaryPrivateIpAddressCount': 123, | |||
| 'SubnetId': 'string' | |||
| }, | |||
| },. | |||
| @@ -431,7 +431,7 @@ def build_launch_specification(launch_spec): | |||
| block_device_mappings | |||
| monitoring | |||
| placement | |||
| iam_instance_profile | |||
| iam_instance_profile. | |||
There was a problem hiding this comment.
Should we be changing the formatting here?
| @@ -320,7 +320,7 @@ def create_dhcp_config(module): | |||
| 'Values': [{'Value': 'us-west-2.compute.internal'}]}, | |||
| {'Key': 'domain-name-servers', | |||
| 'Values': [{'Value': 'AmazonProvidedDNS'}]}, | |||
| ...], | |||
| ...],. | |||
amazon.aws 8.0.0 deprecations - test cleanup SUMMARY iam_role moved all of the return values under .iam_role, rather than returning a tangled mess at the top level ISSUE TYPE Feature Pull Request COMPONENT NAME tests/integration/targets/config/tasks/main.yaml tests/integration/targets/ec2_launch_template/tasks/iam_instance_role.yml tests/integration/targets/ecs_cluster/tasks/20_ecs_service.yml tests/integration/targets/eks_cluster/tasks/full_test.yml tests/integration/targets/eks_fargate_profile/tasks/create_eks_cluster.yml tests/integration/targets/eks_fargate_profile/tasks/full_test.yml tests/integration/targets/eks_nodegroup/tasks/dependecies.yml tests/integration/targets/eks_nodegroup/tasks/full_test.yml ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@5cb20f7
SUMMARY
Test ruff. For more details see ansible-collections/cloud-content-handbook#22
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION