New module - autoscaling_instance(_info) #2296
Conversation
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
force-pushed
the
autoscaling/instances
branch
from
43d99b1
to
d4d2b4b
Compare
tremble
force-pushed
the
autoscaling/instances
branch
from
d4d2b4b
to
6d534b0
Compare
tremble
changed the title
tremble
force-pushed
the
autoscaling/instances
branch
2 times, most recently
from
fdd68ad
to
425286c
Compare
SUMMARY Having everything in waiters.py today means that every time we add a new waiter we trigger a lot of integration tests. Adding this Factory gives us a basis to work upon for splitting the code up. It's based upon the Factory in community.aws, but doesn't come with the assumption that we'll have the module/client available to us when we instantiate the factory. While similar to the current code in waiters.py, this factory supports: waiter definitions stored on a per-API basis waiter definitions outside of amazon.aws Because touching the existing waiters.py would trigger a mass of integration tests, this puts the factory into waiter.py instead of waiters.py. Additionally, putting it in waiter.py also gives us a long term route to split the current waiters off and out of waiters.py without generating import loops. (Putting it in waiters.py would mean that a per-API file would need to import waiters.py, and thus waiters.py couldn't import the new file to provide backwards compatibility with today's implementation) ISSUE TYPE Feature Pull Request COMPONENT NAME plugin/module_utils/waiter.py ADDITIONAL INFORMATION See #2296 for an example of using this (module_utils._autoscaling.waiters) Reviewed-by: Alina Buzachis
tremble
force-pushed
the
autoscaling/instances
branch
from
df9061f
to
246d2be
Compare
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 4m 54s |
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 23s |
tremble
force-pushed
the
autoscaling/instances
branch
from
73eca48
to
beacb22
Compare
|
Build failed.
|
tremble
force-pushed
the
autoscaling/instances
branch
from
beacb22
to
6139c2e
Compare
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 38s |
|
Testing passes locally, but they have been temporarily disabled due to missing permissions that will be resolved once version 9.0 is released. |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 57s |
softwarefactory-project-zuul
bot
merged commit 1700d40
into
ansible-collections:main
Depends-On: ansible/ansible-zuul-jobs#1885
SUMMARY
Looking to simplify autoscaling_group, add autoscaling_instance as a new module so we can deprecate support for it in autoscaling_group
ISSUE TYPE
COMPONENT NAME
autoscaling_instance
ADDITIONAL INFORMATION