Add permission to upload ACL in ExtraArgs

[cbcoutinho]

Use the permission ACL when uploading objects (fixes #219)

[ansibullbot]

cc @jillr @lwade @s-hertel @tremble @wimnat
click here for bot help

[alinabuzachis]

@cbcoutinho Thank you for your contribution. Could you kindly include a functional test and a changelog? Thanks.

[tremble]

The change looks sane, 3 minor issues:

• Please add a changelog fragment (https://docs.ansible.com/ansible/latest/community/development_process.html#changelogs-how-to)
• To ensure your docs change isn't automatically overwritten please update the docs at the start of the module (the .rst is auto generated)
• To reduce the risk of a regression being introduced please add an integration test entry (tests/integration/targets/aws_s3/tasks/main.yml). You'll need to update the bucket policy and then upload using the new features.

[cbcoutinho]

@cbcoutinho Thank you for your contribution. Could you kindly include a functional test and a changelog? Thanks.

@alinabuzachis How do you recommend testing this functionality? Is it possible to mock S3 bucket ACLs or do you have to supply S3 credentials and test against existing infra?

[tremble]

@alinabuzachis How do you recommend testing this functionality? Is it possible to mock S3 bucket ACLs or do you have to supply S3 credentials and test against existing infra?

We have a set of integration tests which are just Ansible roles which will be run in CI (tests/integration/targets/aws_s3/tasks/main.yml) temporary credentials will be automatically supplied (see the module_defaults at the start of the yaml file)

[cbcoutinho]

@tremble I'm a little unclear exactly how to test this, and I'm having trouble understanding the testing framework here. Is it possible to specify the IAM role used during the PUT operation? Ideally, I would want to XFAIL a test that uses the wrong permission and another that passes using the correct, but I don't know how to declare that using these targets.

I'm assuming the credentials used to create the bucket are the same used to do the uploading, which is not the scenario I'm trying to address.

[cbcoutinho]

Setting this PR as a draft to denote WIP