Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] test EE tests #432

Closed
wants to merge 1 commit into from
Closed

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Aug 3, 2021

SUMMARY

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

zuul.yaml

Depends-On: ansible/ansible-zuul-jobs#1062
Depends-On: ansible/ansible-zuul-jobs#1046

@ansibullbot ansibullbot added bug This issue/PR relates to a bug community_review needs_triage labels Aug 3, 2021
@Akasurde
Copy link
Member Author

Akasurde commented Aug 3, 2021

recheck

1 similar comment
@Akasurde
Copy link
Member Author

Akasurde commented Aug 3, 2021

recheck

@tremble
Copy link
Contributor

tremble commented Aug 10, 2021

@Akasurde Please can we rename these jobs "network-ee" is misleading. Something like "ansible-ee-" would be better.

@Akasurde
Copy link
Member Author

@tremble This is an already written job and shared by multiple teams. So I think @pabelanger is the right person to answer this.

@Akasurde Akasurde closed this Aug 14, 2021
@Akasurde Akasurde reopened this Aug 14, 2021
@pabelanger
Copy link
Contributor

@Akasurde @tremble We can rename them, but we need to bikeshed on the format. This is a test EE, so we likly should rename to test-ee however, it will be work to do so.

requirements.txt Outdated Show resolved Hide resolved
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@pabelanger
Copy link
Contributor

recheck

@pabelanger
Copy link
Contributor

Sorry, I caused a bug in the docker jobs over the weekend this is now fixed by: ansible/ansible-zuul-jobs#1062

@pabelanger
Copy link
Contributor

Added ansible/ansible-zuul-jobs#1046 too

@pabelanger
Copy link
Contributor

recheck

@pabelanger
Copy link
Contributor

failure looks to be network related

@pabelanger
Copy link
Contributor

recheck

@Akasurde Akasurde closed this Aug 16, 2021
@Akasurde Akasurde deleted the ee_dep branch August 16, 2021 14:31
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
New Module: Amazon MQ

SUMMARY
replicates ansible-collections#266 as suggested
This PR contains some basic support for Amazon MQ. It covers

Managing Amazon MQ brokers
Managing Amazon MQ configurations
Managing Amazon MQ (local) users

ISSUE TYPE

New Module Pull Request

COMPONENT NAME
Amazon MQ
ADDITIONAL INFORMATION
We use those modules to manage our MQ Brokers. The context of usage is

brokers are created by different means (e.g. terraform) - but the module is capable of doing that as well
we've developed a custom role around those modules
to manage MQ user credentials we use another local extension of amazon.aws collection (will come as separate PR) that interfaces with AWS SecretsManager
that role uses the reboot broker feature (part of this PR) to implement a custom handler that reboots a broker whenever a configuration run sees any changes in configuration and/or users

The functionality of the added modules is illustrated in the added test suite (tests/integration/targets/mq) some of them still require a running MQ broker to be usable.
Missing functionality/limitations:

requires a recent version of boto3 library  (older versions don't support all Amazon MQ features used here)
API results are returned "as is", i.e. there's no conversion from camel case yaml to snake yaml

mq_broker.py

no support for LDAP connection (external user management)
update configuration only supported through mq_broker_config.py
known to work only with EngineType=ACTIVEMQ (proper support for RABBITMQ still missing)

mq_broker_config.py

needs proper XML comparison between current and desired configuration (current one is too simplistic)
only tested with ActiveMQ configurations

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
New Module: Amazon MQ

SUMMARY
replicates ansible-collections#266 as suggested
This PR contains some basic support for Amazon MQ. It covers

Managing Amazon MQ brokers
Managing Amazon MQ configurations
Managing Amazon MQ (local) users

ISSUE TYPE

New Module Pull Request

COMPONENT NAME
Amazon MQ
ADDITIONAL INFORMATION
We use those modules to manage our MQ Brokers. The context of usage is

brokers are created by different means (e.g. terraform) - but the module is capable of doing that as well
we've developed a custom role around those modules
to manage MQ user credentials we use another local extension of amazon.aws collection (will come as separate PR) that interfaces with AWS SecretsManager
that role uses the reboot broker feature (part of this PR) to implement a custom handler that reboots a broker whenever a configuration run sees any changes in configuration and/or users

The functionality of the added modules is illustrated in the added test suite (tests/integration/targets/mq) some of them still require a running MQ broker to be usable.
Missing functionality/limitations:

requires a recent version of boto3 library  (older versions don't support all Amazon MQ features used here)
API results are returned "as is", i.e. there's no conversion from camel case yaml to snake yaml

mq_broker.py

no support for LDAP connection (external user management)
update configuration only supported through mq_broker_config.py
known to work only with EngineType=ACTIVEMQ (proper support for RABBITMQ still missing)

mq_broker_config.py

needs proper XML comparison between current and desired configuration (current one is too simplistic)
only tested with ActiveMQ configurations

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
New Module: Amazon MQ

SUMMARY
replicates ansible-collections#266 as suggested
This PR contains some basic support for Amazon MQ. It covers

Managing Amazon MQ brokers
Managing Amazon MQ configurations
Managing Amazon MQ (local) users

ISSUE TYPE

New Module Pull Request

COMPONENT NAME
Amazon MQ
ADDITIONAL INFORMATION
We use those modules to manage our MQ Brokers. The context of usage is

brokers are created by different means (e.g. terraform) - but the module is capable of doing that as well
we've developed a custom role around those modules
to manage MQ user credentials we use another local extension of amazon.aws collection (will come as separate PR) that interfaces with AWS SecretsManager
that role uses the reboot broker feature (part of this PR) to implement a custom handler that reboots a broker whenever a configuration run sees any changes in configuration and/or users

The functionality of the added modules is illustrated in the added test suite (tests/integration/targets/mq) some of them still require a running MQ broker to be usable.
Missing functionality/limitations:

requires a recent version of boto3 library  (older versions don't support all Amazon MQ features used here)
API results are returned "as is", i.e. there's no conversion from camel case yaml to snake yaml

mq_broker.py

no support for LDAP connection (external user management)
update configuration only supported through mq_broker_config.py
known to work only with EngineType=ACTIVEMQ (proper support for RABBITMQ still missing)

mq_broker_config.py

needs proper XML comparison between current and desired configuration (current one is too simplistic)
only tested with ActiveMQ configurations

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug community_review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants