-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rework s3_bucket and ec2_instance tests to make sure they have the right botocore available for tests needing recent botocore #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
needs_triage
plugins
plugin (any type)
tests
tests
labels
Sep 10, 2021
tremble
force-pushed
the
tests/botocore
branch
2 times, most recently
from
September 10, 2021 12:32
123b221
to
42c77fe
Compare
…ght botocore available for tests needing recent botocore
tremble
force-pushed
the
tests/botocore
branch
from
September 10, 2021 13:52
42c77fe
to
c66b854
Compare
abhattacharyaNS1
pushed a commit
to abhattacharyaNS1/amazon.aws
that referenced
this pull request
Sep 10, 2021
…ollections#496) * Test idempotency with adding a route * tweak changelog to include bugfix link This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@9623b6c
recheck |
alinabuzachis
approved these changes
Sep 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
First attempt at gating failed due to problems with CI itself. |
ansible-zuul bot
pushed a commit
that referenced
this pull request
Sep 17, 2021
…404) Add constraints.txt and requirements.txt for unit/integration tests SUMMARY Now that we state that we support specific minimum versions of the AWS SDKs, make sure we base our unit/integration tests against them such that modules need to explicitly test/request newer versions of the SDKs. ISSUE TYPE Feature Pull Request COMPONENT NAME tests/integration tests/unit ADDITIONAL INFORMATION Once merged into amazon.aws we should merge this into community.aws Depends-On: #453 Depends-On: #454 Depends-On: #450 Depends-On: #496 See also: ansible/ansible-zuul-jobs#991 Reviewed-by: Jill R <None> Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…ollections#496) * Test idempotency with adding a route * tweak changelog to include bugfix link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
needs_triage
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
s3_bucket
ec2_instance
ADDITIONAL INFORMATION