aws_ec2: remove py2 compatiblity header #505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
inventory
mdellweg
pushed a commit
to mdellweg/amazon.aws
that referenced
this pull request
Sep 16, 2021
…le-collections#505) * ec2_instance don't change termination protection in check mode Fixes: ansible/ansible/issues/67716 Extend termination protection tests * Set the path for the aws CLI tool - setting ansible_python_interpreter updates the python search path but not the shell search path * changelog Co-authored-by: Mark Chappell <mchappel@redhat.com>
|
recheck |
1 similar comment
|
recheck |
|
Closing this. Until the containers support disabling the python2 compatability headers we'll still need to add them. Filling ignore.txt with skip/ignore entries just makes the ignore.txt files unreadable. |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…le-collections#505) * ec2_instance don't change termination protection in check mode Fixes: ansible/ansible/issues/67716 Extend termination protection tests * Set the path for the aws CLI tool - setting ansible_python_interpreter updates the python search path but not the shell search path * changelog Co-authored-by: Mark Chappell <mchappel@redhat.com>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…le-collections#505) * ec2_instance don't change termination protection in check mode Fixes: ansible/ansible/issues/67716 Extend termination protection tests * Set the path for the aws CLI tool - setting ansible_python_interpreter updates the python search path but not the shell search path * changelog Co-authored-by: Mark Chappell <mchappel@redhat.com>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…le-collections#505) * ec2_instance don't change termination protection in check mode Fixes: ansible/ansible/issues/67716 Extend termination protection tests * Set the path for the aws CLI tool - setting ansible_python_interpreter updates the python search path but not the shell search path * changelog Co-authored-by: Mark Chappell <mchappel@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#991