-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2_vpc_igw: fix 'NoneType' object is not subscriptable #672
ec2_vpc_igw: fix 'NoneType' object is not subscriptable #672
Conversation
Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
Build failed.
|
recheck |
Build failed.
|
recheck |
Build succeeded.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alinabuzachis
Build succeeded (gate pipeline).
|
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #679 🤖 @patchback |
Stabilize ec2_eip module SUMMARY fixed check_mode issues added integration tests for check_mode / idempotency updated json returned when state = absent for clarity removed json_query references fixes #159 Depends-On: ansible-collections/amazon.aws#672 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
ec2_vpc_igw: fix 'NoneType' object is not subscriptable SUMMARY ec2_vpc_igw: fix 'NoneType' object is not subscriptable ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 395b730)
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #680 🤖 @patchback |
ec2_vpc_igw: fix 'NoneType' object is not subscriptable SUMMARY ec2_vpc_igw: fix 'NoneType' object is not subscriptable ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_vpc_igw ADDITIONAL INFORMATION Reviewed-by: Jill R <None> Reviewed-by: Joseph Torcasso <None> (cherry picked from commit 395b730)
backport-3: Stabilize ec2_eip module (#936) Backport into stable-3 of #936 with commit id: d0596e3 SUMMARY fixed check_mode issues added integration tests for check_mode / idempotency updated json returned when state = absent for clarity removed json_query references fixes #159 Depends-On: ansible-collections/amazon.aws#672 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip Reviewed-by: Mark Woolley Reviewed-by: Mark Chappell Reviewed-by: Alina Buzachis Reviewed-by: Joseph Torcasso Reviewed-by: Jill R SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION
Stabilize ec2_eip module SUMMARY fixed check_mode issues added integration tests for check_mode / idempotency updated json returned when state = absent for clarity removed json_query references fixes ansible-collections#159 Depends-On: ansible-collections#672 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d0596e3
Stabilize ec2_eip module SUMMARY fixed check_mode issues added integration tests for check_mode / idempotency updated json returned when state = absent for clarity removed json_query references fixes ansible-collections#159 Depends-On: ansible-collections#672 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None> This commit was initially merged in https://github.com/ansible-collections/community.aws See: ansible-collections/community.aws@d0596e3
Stabilize ec2_eip module SUMMARY fixed check_mode issues added integration tests for check_mode / idempotency updated json returned when state = absent for clarity removed json_query references fixes ansible-collections#159 Depends-On: ansible-collections#672 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
…ible-collections/community.aws#672) (ansible-collections#987) Delete ec2_vpc_route_table* since already promoted While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ansible-collections#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything. SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
Stabilize ec2_eip module SUMMARY fixed check_mode issues added integration tests for check_mode / idempotency updated json returned when state = absent for clarity removed json_query references fixes ansible-collections#159 Depends-On: ansible-collections#672 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_eip Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
…ible-collections/community.aws#672) (ansible-collections#987) Delete ec2_vpc_route_table* since already promoted While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ansible-collections#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything. SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
…_ec2_vpc_endpoint Migrate ec2_vpc_endpoint* modules and tests Depends-On: ansible-collections#435 Remove ec2_vpc_endpoint* modules and tests These modules have been migrated to amazon.aws Update runtime.yml with redirects to that collection Update ignore files Reviewed-by: Mark Chappell <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
…ible-collections/community.aws#672) (ansible-collections#987) Delete ec2_vpc_route_table* since already promoted While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ansible-collections#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything. SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Joseph Torcasso <None> Reviewed-by: Jill R <None>
SUMMARY
ec2_vpc_igw: fix 'NoneType' object is not subscriptable
ISSUE TYPE
COMPONENT NAME
ec2_vpc_igw
ADDITIONAL INFORMATION