Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ec2_vpc_igw: fix 'NoneType' object is not subscriptable #672

Conversation

alinabuzachis
Copy link
Collaborator

SUMMARY

ec2_vpc_igw: fix 'NoneType' object is not subscriptable

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ec2_vpc_igw

ADDITIONAL INFORMATION

Signed-off-by: Alina Buzachis <abuzachis@redhat.com>
@alinabuzachis alinabuzachis linked an issue Feb 11, 2022 that may be closed by this pull request
1 task
@ansibullbot
Copy link

@alinabuzachis
Copy link
Collaborator Author

recheck

@alinabuzachis
Copy link
Collaborator Author

recheck

Copy link
Contributor

@jatorcasso jatorcasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jillr jillr added the mergeit Merge the PR (SoftwareFactory) label Feb 16, 2022
@alinabuzachis alinabuzachis added backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch labels Feb 16, 2022
@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 395b730 into ansible-collections:main Feb 16, 2022
@patchback
Copy link

patchback bot commented Feb 16, 2022

Backport to stable-2: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-2/395b730c9cfe73e98ecc346859d500a89bc09973/pr-672

Backported as #679

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

softwarefactory-project-zuul bot pushed a commit to ansible-collections/community.aws that referenced this pull request Feb 16, 2022
Stabilize ec2_eip module

SUMMARY

fixed check_mode issues
added integration tests for check_mode / idempotency
updated json returned when state = absent for clarity
removed json_query references
fixes #159

Depends-On: ansible-collections/amazon.aws#672
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eip

Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
patchback bot pushed a commit that referenced this pull request Feb 16, 2022
ec2_vpc_igw: fix 'NoneType' object is not subscriptable

SUMMARY

ec2_vpc_igw: fix 'NoneType' object is not subscriptable

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_vpc_igw
ADDITIONAL INFORMATION

Reviewed-by: Jill R <None>
Reviewed-by: Joseph Torcasso <None>
(cherry picked from commit 395b730)
@patchback
Copy link

patchback bot commented Feb 16, 2022

Backport to stable-3: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-3/395b730c9cfe73e98ecc346859d500a89bc09973/pr-672

Backported as #680

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 16, 2022
ec2_vpc_igw: fix 'NoneType' object is not subscriptable

SUMMARY

ec2_vpc_igw: fix 'NoneType' object is not subscriptable

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ec2_vpc_igw
ADDITIONAL INFORMATION

Reviewed-by: Jill R <None>
Reviewed-by: Joseph Torcasso <None>
(cherry picked from commit 395b730)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 17, 2022
[PR #672/395b730c backport][stable-2] ec2_vpc_igw: fix 'NoneType' object is not subscriptable

This is a backport of PR #672 as merged into main (395b730).
SUMMARY

ec2_vpc_igw: fix 'NoneType' object is not subscriptable

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_vpc_igw
ADDITIONAL INFORMATION
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Feb 17, 2022
[PR #672/395b730c backport][stable-3] ec2_vpc_igw: fix 'NoneType' object is not subscriptable

This is a backport of PR #672 as merged into main (395b730).
SUMMARY

ec2_vpc_igw: fix 'NoneType' object is not subscriptable

ISSUE TYPE


Bugfix Pull Request

COMPONENT NAME

ec2_vpc_igw
ADDITIONAL INFORMATION
softwarefactory-project-zuul bot pushed a commit to ansible-collections/community.aws that referenced this pull request Feb 23, 2022
backport-3: Stabilize ec2_eip module (#936) 

Backport into stable-3 of #936 with commit id: d0596e3
SUMMARY
fixed check_mode issues
added integration tests for check_mode / idempotency
updated json returned when state = absent for clarity
removed json_query references
fixes #159
Depends-On: ansible-collections/amazon.aws#672
ISSUE TYPE
Feature Pull Request
COMPONENT NAME
ec2_eip
Reviewed-by: Mark Woolley 
Reviewed-by: Mark Chappell 
Reviewed-by: Alina Buzachis 
Reviewed-by: Joseph Torcasso 
Reviewed-by: Jill R 
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 16, 2022
Stabilize ec2_eip module

SUMMARY

fixed check_mode issues
added integration tests for check_mode / idempotency
updated json returned when state = absent for clarity
removed json_query references
fixes ansible-collections#159

Depends-On: ansible-collections#672
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eip

Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@d0596e3
goneri pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Sep 21, 2022
Stabilize ec2_eip module

SUMMARY

fixed check_mode issues
added integration tests for check_mode / idempotency
updated json returned when state = absent for clarity
removed json_query references
fixes ansible-collections#159

Depends-On: ansible-collections#672
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eip

Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@d0596e3
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Stabilize ec2_eip module

SUMMARY

fixed check_mode issues
added integration tests for check_mode / idempotency
updated json returned when state = absent for clarity
removed json_query references
fixes ansible-collections#159

Depends-On: ansible-collections#672
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eip

Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ible-collections/community.aws#672) (ansible-collections#987)

Delete ec2_vpc_route_table* since already promoted 

While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ansible-collections#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything.
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
Stabilize ec2_eip module

SUMMARY

fixed check_mode issues
added integration tests for check_mode / idempotency
updated json returned when state = absent for clarity
removed json_query references
fixes ansible-collections#159

Depends-On: ansible-collections#672
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eip

Reviewed-by: Mark Woolley <mw@marknet15.com>
Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
…ible-collections/community.aws#672) (ansible-collections#987)

Delete ec2_vpc_route_table* since already promoted 

While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ansible-collections#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything.
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…_ec2_vpc_endpoint

Migrate ec2_vpc_endpoint* modules and tests

Depends-On: ansible-collections#435
Remove ec2_vpc_endpoint* modules and tests
These modules have been migrated to amazon.aws
Update runtime.yml with redirects to that collection
Update ignore files

Reviewed-by: Mark Chappell <None>
Reviewed-by: Alina Buzachis <None>
Reviewed-by: None <None>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
…ible-collections/community.aws#672) (ansible-collections#987)

Delete ec2_vpc_route_table* since already promoted 

While migrating ec2_vpc_route_table and ec2_vpc_route_table_info (ansible-collections#672) from community.aws to amazon.aws, we forget to delete the modules from the community.aws collection after the promotion. As of now, the modules within community.aws have not received any new updates, so we can remove them without backporting anything.
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Markus Bergholz <git@osuv.de>
Reviewed-by: Joseph Torcasso <None>
Reviewed-by: Jill R <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-2 PR should be backported to the stable-2 branch backport-3 PR should be backported to the stable-3 branch bug This issue/PR relates to a bug community_review has_issue mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) small_patch Hopefully easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'NoneType' object is not subscriptable error in ec2_vpc_igw module
4 participants