Fix deprecation warning scope #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
jatorcasso
approved these changes
Mar 20, 2022
alinabuzachis
added
backport-2
Added. |
mandar242
force-pushed
the
ec2_instance_deprecation_fix
branch
from
c54459a
to
38172ca
Compare
|
recheck |
alinabuzachis
approved these changes
Mar 21, 2022
Backport to stable-2: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply d6b1186 on top of patchback/backports/stable-2/d6b118644c17ed900de83810d02f1a8535d40903/pr-719 Backporting merged PR #719 into main
🤖 @patchback |
Backport to stable-3: 💚 backport PR created✅ Backport PR branch: Backported as #724 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Mar 21, 2022
Fix deprecation warning scope SUMMARY Fix deprecation warning scope to be not displayed while terminating instances. Fixes #689 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_instance Reviewed-by: Joseph Torcasso <None> Reviewed-by: Alina Buzachis <None> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> (cherry picked from commit d6b1186)
1 task
1 task
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
…t_subnet_group Add integration tests for redshift_subnet_group SUMMARY Add integration tests for redshift_subnet_group CI / IAM Permissions ISSUE TYPE Feature Pull Request COMPONENT NAME redshift_subnet_group ADDITIONAL INFORMATION Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…t_subnet_group Add integration tests for redshift_subnet_group SUMMARY Add integration tests for redshift_subnet_group CI / IAM Permissions ISSUE TYPE Feature Pull Request COMPONENT NAME redshift_subnet_group ADDITIONAL INFORMATION Reviewed-by: None <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
…t_subnet_group Migrate redshift_subnet_group to boto3 SUMMARY Migrate redshift_subnet_group to boto3 note: while there additional features (tagging springs to mind) that could be added, I'm trying to avoid scope creep and mostly just want to knock out migrations of the remaining old-boto modules. That said, I am converting tags using the boto3_tag_list_to_ansible_dict helper, in the return values this is just to avoid needing to change formats in future ISSUE TYPE Feature Pull Request COMPONENT NAME redshift_subnet_group ADDITIONAL INFORMATION Depends-On: ansible-collections#719 Reviewed-by: Markus Bergholz <git@osuv.de> Reviewed-by: Alina Buzachis <None> Reviewed-by: None <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix deprecation warning scope to be not displayed while terminating instances.
Fixes #689
ISSUE TYPE
COMPONENT NAME
ec2_instance