Integration test dependency cleanup #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
|
recheck |
|
recheck |
1 similar comment
|
recheck |
alinabuzachis
approved these changes
Apr 22, 2022
markuman
approved these changes
Apr 22, 2022
|
regate |
|
regate |
tremble
force-pushed
the
integration/cleanup
branch
from
859d795
to
7bc3b43
Compare
Remove dependencies on "setup_remote_dir" where it's not being used. Move path to /var/tmp (/tmp is often tmpfs and can cause problems)
tremble
force-pushed
the
integration/cleanup
branch
from
7bc3b43
to
d2aba62
Compare
|
recheck |
|
recheck |
|
regate |
|
regate |
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
) ec2_lc: add volume throughput parameter support SUMMARY Adding throughput parameter support to ec2_lc. Fixes ansible-collections#784. ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.ec2_lc UPDATE: Integration tests being added in a separate PR: ansible-collections#824 Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
) ec2_lc: add volume throughput parameter support SUMMARY Adding throughput parameter support to ec2_lc. Fixes ansible-collections#784. ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.ec2_lc UPDATE: Integration tests being added in a separate PR: ansible-collections#824 Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
) ec2_lc: add volume throughput parameter support SUMMARY Adding throughput parameter support to ec2_lc. Fixes ansible-collections#784. ISSUE TYPE Feature Pull Request COMPONENT NAME community.aws.ec2_lc UPDATE: Integration tests being added in a separate PR: ansible-collections#824 Reviewed-by: Alina Buzachis <None> Reviewed-by: Jill R <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
tests/integration/targets
ADDITIONAL INFORMATION
By cleaning up what we have we reduce the chance of people copying things about "because that's what test XYZ did".