-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ec2_tag - remove deprecated 'state=list' #829
Merged
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:deprecation/4.0.0/ec2_tag
May 25, 2022
Merged
ec2_tag - remove deprecated 'state=list' #829
softwarefactory-project-zuul
merged 1 commit into
ansible-collections:main
from
tremble:deprecation/4.0.0/ec2_tag
May 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremble
added
the
do_not_backport
This PR should not be backported to stable- branches unless absolutely necessary
label
May 24, 2022
ansibullbot
added
community_review
feature
This issue/PR relates to a feature request
integration
tests/integration
module
module
plugins
plugin (any type)
tests
tests
labels
May 24, 2022
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
deprecation/4.0.0/ec2_tag
branch
from
May 24, 2022 12:24
382f3a6
to
55e2c51
Compare
alinabuzachis
approved these changes
May 25, 2022
ansibullbot
added
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
and removed
community_review
labels
May 25, 2022
tremble
force-pushed
the
deprecation/4.0.0/ec2_tag
branch
from
May 25, 2022 10:12
55e2c51
to
ee1e928
Compare
ansibullbot
added
community_review
and removed
needs_rebase
https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
labels
May 25, 2022
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 30, 2022
ec2_tag - simplified 'required' logic SUMMARY We removed the 'list' functionality in #829 which now makes tags required for all states, simplify the logic. ISSUE TYPE Docs Pull Request Feature Pull Request COMPONENT NAME plugins/modules/ec2_tag.py ADDITIONAL INFORMATION Not added a changelog, this rolls up into the change made for #829 which has its own changelog Reviewed-by: Alina Buzachis <None>
1 task
1 task
1 task
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Add dynamodb table class support SUMMARY Add support for defining a TableClass on DynamoDB tables. TableClass was introduced as part of botocore version 1.23.18 https://github.com/boto/botocore/blob/develop/CHANGELOG.rst#12318 Fixes: ansible-collections#829 ISSUE TYPE Feature Pull Request COMPONENT NAME dynamodb_table ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/dynamodb.html#DynamoDB.Client.create_table https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/dynamodb.html#DynamoDB.Client.update_table Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Jill R <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Sep 18, 2023
Add dynamodb table class support SUMMARY Add support for defining a TableClass on DynamoDB tables. TableClass was introduced as part of botocore version 1.23.18 https://github.com/boto/botocore/blob/develop/CHANGELOG.rst#12318 Fixes: ansible-collections#829 ISSUE TYPE Feature Pull Request COMPONENT NAME dynamodb_table ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/dynamodb.html#DynamoDB.Client.create_table https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/dynamodb.html#DynamoDB.Client.update_table Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Jill R <None>
abikouo
pushed a commit
to abikouo/amazon.aws
that referenced
this pull request
Oct 24, 2023
Add dynamodb table class support SUMMARY Add support for defining a TableClass on DynamoDB tables. TableClass was introduced as part of botocore version 1.23.18 https://github.com/boto/botocore/blob/develop/CHANGELOG.rst#12318 Fixes: ansible-collections#829 ISSUE TYPE Feature Pull Request COMPONENT NAME dynamodb_table ADDITIONAL INFORMATION https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/dynamodb.html#DynamoDB.Client.create_table https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/dynamodb.html#DynamoDB.Client.update_table Reviewed-by: Alina Buzachis <None> Reviewed-by: Mark Woolley <mw@marknet15.com> Reviewed-by: Jill R <None>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community_review
do_not_backport
This PR should not be backported to stable- branches unless absolutely necessary
feature
This issue/PR relates to a feature request
integration
tests/integration
mergeit
Merge the PR (SoftwareFactory)
module
module
plugins
plugin (any type)
tests
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Remove the deprecated state list from ec2_tag. This functionality has been moved to the ec2_tag_info module.
ISSUE TYPE
COMPONENT NAME
ec2_tag
ADDITIONAL INFORMATION
See also ansible/ansible#66840