Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ADAL from dependencies and migrate ADAL to MSAL #1239

Merged
merged 7 commits into from
Aug 11, 2023

Conversation

Fred-sun
Copy link
Collaborator

@Fred-sun Fred-sun commented Aug 9, 2023

SUMMARY

Migrate ADAL to MSAL

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module Pull Request
COMPONENT NAME

azure_rm_common.py

ADDITIONAL INFORMATION

@xuzhang3 xuzhang3 self-assigned this Aug 10, 2023
@xuzhang3 xuzhang3 added enhancement New feature or request high_priority High priority dependencies Pull requests that update a dependency file labels Aug 10, 2023
@Fred-sun Fred-sun added the ready_for_review The PR has been modified and can be reviewed and merged label Aug 10, 2023
@Fred-sun
Copy link
Collaborator Author

@xuzhang3

@xuzhang3 xuzhang3 merged commit 86e0f07 into ansible-collections:dev Aug 11, 2023
@xuzhang3
Copy link
Collaborator

This PR removes the direct dependency of ADAL from azcollection, indirect dependency still exists.

@xuzhang3 xuzhang3 changed the title Migrate ADAL to MSAL Remove ADAL from dependencies and migrate ADAL to MSAL Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request high_priority High priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants