Added support for Windows 2022 nodes #1377
Conversation
Fred-sun
added
medium_priority
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
Co-authored-by: Fred-sun <37327967+Fred-sun@users.noreply.github.com>
|
@xrow What is your version of azure-mgmt-containerservice? |
|
@Fred-sun I believe it was using latest, but i acutally do not know. I do not know how to test. |
|
@xrow I am currently using the version of "azure-mgmt-containerservice==20.0.0", I will upgrade to the latest version test, thank you! |
|
@Fred-sun Based on your feedback I added AzureLinux as a sku too. I tought that is the most reasonable todo. |
plugins/modules/azure_rm_subnet.py
Outdated
| @@ -343,16 +343,6 @@ | |||
| serviceName=dict( | |||
| type='str', | |||
| required=True, | |||
| choices=['Microsoft.Web/serverFarms', 'Microsoft.ContainerInstance/containerGroups', 'Microsoft.Netapp/volumes', | |||
There was a problem hiding this comment.
Why delete the choices？ Please keep！
There was a problem hiding this comment.
@Fred-sun I am sorry. That is actually part of a different pull request I am planning. Let me figure out on how to have multipole pulls at the same time. Can you mean comment of the remaining open topics? I will revert this part later. Sorry again, I am no so strong with pull requests and its management.
|
@xrow Other os_sku options will only be supported in versions higher than azure-mgmt-containerservice=20.0.0. I will upgrade azure-mgmt-containerservice first, and then push forward the PR merge in testing. Thank you! |
|
Thank you too... |
|
@xrow This branch has conflicts, Please help to resolved. The relate package has been upgrade. when you resolved, I will review and push for merged as soon as possible! Thank you very much! |
|
@Fred-sun can you review again? |
| @@ -615,6 +623,12 @@ | |||
| type: str | |||
| returned: always | |||
| sample: Linux | |||
| os_sku: | |||
There was a problem hiding this comment.
duplication of key "os_sku" in mapping ( line 717)
| @@ -64,6 +64,14 @@ | |||
| choices: | |||
| - Linux | |||
| - Windows | |||
| os_sku: | |||
There was a problem hiding this comment.
duplication of key "os_sku" in mapping( line 127)
| @@ -808,6 +822,10 @@ def __init__(self): | |||
| type='str', | |||
| choices=['Linux', 'Windows'] | |||
| ), | |||
| os_sku=dict( | |||
There was a problem hiding this comment.
duplication of key "os_sku" in mapping(line 861)
|
kindly ping! |
|
@Fred-sun Hi, Fred I am sorry I am not allowed to dedicate time on this any more by the organisation I am working for. I guess you have to take it from here or close it. I am sorry for it. |
|
@xrow Thank you for your feedback, you can authorize me to maintain this PR together, thank you! |
|
@Fred-sun Please do so! Thank you. |
SUMMARY
The feature adds the capability to create Windows 2022 nodes via the os_sku property.
ISSUE TYPE
COMPONENT NAME
azure_rm_aks