Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symlink requirements-azure.txt from tests/integration #1551

Merged
merged 1 commit into from
May 15, 2024

Conversation

nirarg
Copy link
Collaborator

@nirarg nirarg commented May 8, 2024

SUMMARY

In order to allow running the integration tests inside container (ansible-test integration --docker ...) requirements.txt file need to be in the tests/integration directory Create Symlink to the file located in the root directory

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged medium_priority Medium priority labels May 8, 2024
@Fred-sun
Copy link
Collaborator

Fred-sun commented May 9, 2024

@nirarg The requirements-azure.txt has been renamed to requirements.txt, does it meet your requirements? Do you want to keep this linked file? If so, you will need to update the contents of the file. Thank you!

@Fred-sun Fred-sun added work in In trying to solve, or in working with contributors and removed ready_for_review The PR has been modified and can be reviewed and merged labels May 9, 2024
In order to allow running the integration tests inside container (ansible-test integration --docker ...)
requirements.txt file need to be in the tests/integration directory
Create Symlink to the file located in the root directory
@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels May 9, 2024
@nirarg
Copy link
Collaborator Author

nirarg commented May 9, 2024

@nirarg The requirements-azure.txt has been renamed to requirements.txt, does it meet your requirements? Do you want to keep this linked file? If so, you will need to update the contents of the file. Thank you!

@Fred-sun the symlink is still required for the integration execution within a container
I changed the symlink path according to the new file name
thanks

@Fred-sun
Copy link
Collaborator

Fred-sun commented May 9, 2024

@nirarg Thanks for your feedback! I see!

@xuzhang3 xuzhang3 merged commit b0d29a5 into ansible-collections:dev May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants