-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated code to fetch availability zone info into hostvars #243
updated code to fetch availability zone info into hostvars #243
Conversation
@Fred-sun could you please assign reviewer for this PR ? |
@Fred-sun Could you please look into this PR ? |
Yes, the review of this PR was delayed due to other issues recently, and I will focus on review tomorrow. Thank you! |
@ShwetaliBerad Thank you for your contribution. What is the purpose of this parameter? Can you give us a sample for this parameter? |
@Fred-sun |
@ShwetaliBerad I will review it again. Thank you very much! |
Hi @ShwetaliBerad No problem, but it only supports the ansible version after 2.10. Ansible/plugin/inventory/azure_rm.py will be used before 2.10, thanks! If you want ansible 2.9 to also support it, you need to add patch to 2.9 and modify ansible/plugin/inventory/azure_rm.py. |
I will advance the merger. Thank you! |
@ShwetaliBerad thanks for contributing to the azure collection! According to @Fred-sun 's testing result, this PR will only enable this feature in ansible 2.10+. If your target ansible version is 2.9, then the same change need to be made in ansible 2.9, what you need to do is submit a similar PR targeting ansible2.9-stable. I'll close and merge this one anyway. |
SUMMARY
updated code to fetch availability zone info into hostvars via Azure Inventory Script
#161
ISSUE TYPE
COMPONENT NAME
Dynamic Inventory Script