Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Recovery Services VM Backup Policy #271

Merged
merged 48 commits into from
Oct 26, 2020

Conversation

suyeb786
Copy link
Contributor

@suyeb786 suyeb786 commented Sep 22, 2020

SUMMARY

This module introducing the VM Backup Policy features listed below

  1. Create VM Backup Policy
  2. Delete VM Backup Policy
  3. Get VM Backup Policy Details

#255

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

azure_rm_vmbackuppolicy
azure_rm_vmbackuppolicy_info

ADDITIONAL INFORMATION

Suyeb Ansari and others added 30 commits September 7, 2020 09:59
@Fred-sun Fred-sun added medium_priority Medium priority new_module_pr Add new modules work in In trying to solve, or in working with contributors labels Sep 30, 2020
@suyeb786
Copy link
Contributor Author

suyeb786 commented Oct 6, 2020

Hello @Fred-sun ,
Any update on this.

@Fred-sun
Copy link
Collaborator

Fred-sun commented Oct 9, 2020

@suyeb786 Please help resolve the conflicting files, I will complete the test as soon as possible and recommend merging! Thank you!

@suyeb786
Copy link
Contributor Author

suyeb786 commented Oct 9, 2020

Hi @Fred-sun ,
The conflict has been resolved.

@Fred-sun
Copy link
Collaborator

@suyeb786 The parameters count, months, time, weekdays, weeks of plugins/modules/azure_rm_vmbackuppolicy.py do not have default values ​​and require, but they are defined in argument_spec, and months, weekdays, weeks are not defined type in the document.

plugins/modules/azure_rm_vmbackuppolicy.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_vmbackuppolicy.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_vmbackuppolicy.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_vmbackuppolicy_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_vmbackuppolicy_info.py Outdated Show resolved Hide resolved
plugins/modules/azure_rm_vmbackuppolicy.py Outdated Show resolved Hide resolved
@suyeb786
Copy link
Contributor Author

@Fred-sun any update?

@Fred-sun
Copy link
Collaborator

@Fred-sun any update?

Please add a line in the file below---"plugins/modules/azure_rm_vmbackuppolicy.py validate-modules:parameter-list-no-elements"

tests/sanity/ignore-2.10.txt
tests/sanity/ignore-2.11.txt

@suyeb786
Copy link
Contributor Author

@Fred-sun
tests/sanity/ignore-2.10.txt and tests/sanity/ignore-2.11.txt files have been updated with the following line.
plugins/modules/azure_rm_vmbackuppolicy.py validate-modules:parameter-list-no-elements

@Fred-sun
Copy link
Collaborator

@Fred-sun
tests/sanity/ignore-2.10.txt and tests/sanity/ignore-2.11.txt files have been updated with the following line.
plugins/modules/azure_rm_vmbackuppolicy.py validate-modules:parameter-list-no-elements

Because there is something wrong with azure_rm_recoveryservicesvault, please delete lines 15~19 temporarily, This should be fine! Thank you very much!

@suyeb786
Copy link
Contributor Author

@Fred-sun
line number 15~19 temporarily from which file should I delete?
Please help me with this.

@Fred-sun
Copy link
Collaborator

@Fred-sun
line number 15~19 temporarily from which file should I delete?
Please help me with this.

tests/integration/targets/azure_rm_vmbackuppolicy/tasks/main.yml , Thanks!

@suyeb786
Copy link
Contributor Author

Hello @Fred-sun
tasks/main.yml file is updated.
Thank you

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Oct 23, 2020
@haiyuazhang haiyuazhang merged commit 7d13133 into ansible-collections:dev Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority new_module_pr Add new modules ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants