Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve issue (#268) #307

Conversation

uDuCkV
Copy link
Contributor

@uDuCkV uDuCkV commented Oct 29, 2020

SUMMARY

There was a spelling in default conditions regarding api_server_profile parameters, which led to ignore completely api_server_profile parameters.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

azure_rm_openshiftmanagedcluster

ADDITIONAL INFORMATION

@Fred-sun
Copy link
Collaborator

Fred-sun commented Nov 3, 2020

ready_for_review

Copy link
Collaborator

@Fred-sun Fred-sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.body['properties'] is a dictionary and should get keys()

@Fred-sun Fred-sun added work in In trying to solve, or in working with contributors and removed ready_for_review The PR has been modified and can be reviewed and merged labels Nov 6, 2020
@Fred-sun
Copy link
Collaborator

kindly ping

@Fred-sun
Copy link
Collaborator

@uDuCkV Can I make some updates to your PR? This would recommend merging PR. Thank you very much!

@uDuCkV
Copy link
Contributor Author

uDuCkV commented Jan 13, 2021

Yes of course @Fred-sun. Please be my guest.

@Fred-sun
Copy link
Collaborator

Yes of course @Fred-sun. Please be my guest.

Thanks for your reply, Every is OK! I will push for merged!

@Fred-sun Fred-sun added ready_for_review The PR has been modified and can be reviewed and merged and removed work in In trying to solve, or in working with contributors labels Mar 10, 2021
@haiyuazhang haiyuazhang merged commit 553cbd2 into ansible-collections:dev Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium_priority Medium priority ready_for_review The PR has been modified and can be reviewed and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants